Skip to content

mds: fix bug of dump_resolve_status#49882

Merged
rishabh-d-dave merged 1 commit intoceph:mainfrom
zhsgao:dump_resolve_status
Mar 31, 2023
Merged

mds: fix bug of dump_resolve_status#49882
rishabh-d-dave merged 1 commit intoceph:mainfrom
zhsgao:dump_resolve_status

Conversation

@zhsgao
Copy link
Contributor

@zhsgao zhsgao commented Jan 26, 2023 •
edited by rishabh-d-dave
Loading

Signed-off-by: Zhansong Gao zhsgao@hotmail.com

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
    • minor change; no tracker ticket
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@zhsgao
mds: fix bug of dump_resolve_status
03c62b3 
Signed-off-by: Zhansong Gao <zhsgao@hotmail.com>
@github-actions github-actions bot added the cephfs Ceph File System label Jan 26, 2023
@zhsgao zhsgao mentioned this pull request Jan 26, 2023
Merged
14 tasks
@joscollin joscollin requested a review from a team January 27, 2023 08:57
@dparmar18
Copy link
Contributor

dparmar18 commented Jan 27, 2023

Does #49756 depend on this? Reason to ask is I can see your conversation related to separation of this code from that PR.

@zhsgao
Copy link
Contributor Author

zhsgao commented Jan 29, 2023

Does #49756 depend on this? Reason to ask is I can see your conversation related to separation of this code from that PR.

They are not related. At first I wanted to fix this little problem by the way in another PR, but it's better to separate it.

@dparmar18
Copy link
Contributor

dparmar18 commented Jan 30, 2023

Does #49756 depend on this? Reason to ask is I can see your conversation related to separation of this code from that PR.

They are not related. At first I wanted to fix this little problem by the way in another PR, but it's better to separate it.

Okay so this PR doesn't block #49756 or vice-versa right?

@zhsgao
Copy link
Contributor Author

zhsgao commented Jan 30, 2023

Does #49756 depend on this? Reason to ask is I can see your conversation related to separation of this code from that PR.

They are not related. At first I wanted to fix this little problem by the way in another PR, but it's better to separate it.

Okay so this PR doesn't block #49756 or vice-versa right?

Yes, it's right.

dparmar18
dparmar18 approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@dparmar18 dparmar18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rishabh-d-dave
Copy link
Contributor

rishabh-d-dave commented Jan 30, 2023

@vshankar Should this bug fix be backported? Does this need a tracker ticket?

@rishabh-d-dave rishabh-d-dave added needs-qa wip-rishabh-testing Rishabh's testing label labels Jan 30, 2023
@rishabh-d-dave
Copy link
Contributor

rishabh-d-dave commented Mar 31, 2023

https://tracker.ceph.com/projects/cephfs/wiki/Main#31-Mar-2023

@rishabh-d-dave rishabh-d-dave merged commit 75b12e4 into ceph:main Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rishabh-d-dave rishabh-d-dave rishabh-d-dave approved these changes

@kotreshhr kotreshhr kotreshhr approved these changes

@dparmar18 dparmar18 dparmar18 approved these changes

Assignees

No one assigned

Labels

bug-fix cephfs Ceph File System wip-rishabh-testing Rishabh's testing label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zhsgao @dparmar18 @rishabh-d-dave @kotreshhr