Skip to content

crimson/osd/*recovery_backend: Rename Push/Pull Info/Op#49568

Merged
Matan-B merged 6 commits intoceph:mainfrom
Matan-B:wip-matanb-crimson-modified-ranges
Jan 11, 2023
Merged

crimson/osd/*recovery_backend: Rename Push/Pull Info/Op#49568
Matan-B merged 6 commits intoceph:mainfrom
Matan-B:wip-matanb-crimson-modified-ranges

Conversation

@Matan-B
Copy link
Contributor

@Matan-B Matan-B commented Dec 25, 2022

See: #49546

pi has excessive initials meanings around overlapping files.
pool info, past intervals, pull info, push info, pg info, peer info, PGState instance.

po and pop are also renamed to pull_op and push_op accordingly for better readability.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@Matan-B
crimson/osd/*recovery_backend: Rename PullInfo to pull_info_t
22adfcc 
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B
crimson/osd/*recovery_backend:Rename pi to pull_info
9802136 
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B
crimson/osd/replicated_recovery_backend: Rename pi to push_info
5dca23d 
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B
crimson/osd/recovery_backend: Rename PushInfo to push_info_t
798648f 
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B
crimson/osd/replicated_recovery_backend: Rename po to pull_op
8b70f4e 
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B
crimoson/osd/replicated_recovery_backend: Rename pop to push_op
91309fb 
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B Matan-B requested a review from a team as a code owner December 25, 2022 13:31
@Matan-B Matan-B mentioned this pull request Dec 29, 2022
Merged
20 tasks
@Matan-B
Copy link
Contributor Author

Matan-B commented Jan 11, 2023

jenkins test make check

@Matan-B
Copy link
Contributor Author

Matan-B commented Jan 11, 2023

Merging based on:
https://pulpito.ceph.com/matan-2023-01-11_14:07:51-crimson-rados-wip-matanb-crimson-testing-2.10-v2-distro-crimson-smithi/

@Matan-B Matan-B merged commit 660f7bb into ceph:main Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@athanatos athanatos athanatos approved these changes

@liu-chunmei liu-chunmei liu-chunmei approved these changes

Assignees

No one assigned

Labels

crimson wip-matan-testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Matan-B @athanatos @liu-chunmei