rgw: fix PutObject err affect subsequent request#49474
Closed
rgw: fix PutObject err affect subsequent request#49474
Conversation
Fixes: https://tracker.ceph.com/issues/58286 Signed-off-by: caolei cao.leilc@inspur.com
cbodley
reviewed
Jan 5, 2023
| } | ||
|
|
||
| if (!parser.keep_alive()) { | ||
| if (!parser.keep_alive() || http_ret != 200) { |
Contributor
There was a problem hiding this comment.
i don't think we want to close client connections on any non-200 response. the while (!parser.is_done()) loop just below is meant to recover from this - can you tell why that fails here?
Contributor
There was a problem hiding this comment.
ah, the tracker issue said this was due to interaction with "Expect: 100-continue". i'm testing a fix for that in #49642
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
Contributor
|
fixed in #49642 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/58286
Signed-off-by: caolei cao.leilc@inspur.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows