Skip to content

qa/workunits/rados/test_crash: chown crash files to ceph user#49314

Merged
ljflores merged 2 commits intoceph:mainfrom
SUSE:wip-tserong-qa-crash-chown
Jan 25, 2023
Merged

qa/workunits/rados/test_crash: chown crash files to ceph user#49314
ljflores merged 2 commits intoceph:mainfrom
SUSE:wip-tserong-qa-crash-chown

Conversation

@tserong
Copy link
Member

@tserong tserong commented Dec 8, 2022

This PR also makes ceph-crash log a warning if it can't read any of the crash directories.

Fixes: https://tracker.ceph.com/issues/58098

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@tserong
qa/workunits/rados/test_crash: chown crash files to ceph user
93c0456 
Fixes: https://tracker.ceph.com/issues/58098
Signed-off-by: Tim Serong <tserong@suse.com>
@tserong
ceph-crash: log warning if crash directory unreadable
d139f6d 
This is to aid in debugging in case crashes aren't posted as expected
(see https://tracker.ceph.com/issues/58098 for discussion).

Signed-off-by: Tim Serong <tserong@suse.com>
@tserong tserong requested a review from ljflores December 8, 2022 01:10
@tserong tserong requested a review from a team as a code owner December 8, 2022 01:10
@ljflores
Copy link
Member

ljflores commented Dec 8, 2022

jenkins test make check

ljflores
ljflores approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@ljflores ljflores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems reasonable to me. If it was only a change to the workunit, I would say that just that one test would be sufficient, but since there is a change to src, it won't hurt to put it through the full rados suite.

@ljflores
Copy link
Member

ljflores commented Dec 8, 2022

Thanks for a quick fix @tserong!

@tserong
Copy link
Member Author

tserong commented Dec 9, 2022

jenkins test make check

@tserong
Copy link
Member Author

tserong commented Dec 9, 2022

No problem @ljflores :-)

@tserong
Copy link
Member Author

tserong commented Dec 9, 2022

hrm ... not having much luck with make check here

@tserong
Copy link
Member Author

tserong commented Dec 9, 2022

jenkins test make check

@tserong
Copy link
Member Author

tserong commented Dec 9, 2022

alright, looks like I got lucky ;-)

@tchaikov
Copy link
Contributor

tchaikov commented Dec 9, 2022

yup, it was fixed this morning.

@ljflores
Copy link
Member

ljflores commented Jan 25, 2023

Rados suite review: https://pulpito.ceph.com/?branch=wip-yuri2-testing-2023-01-23-0928

Failures, unrelated:
1. https://tracker.ceph.com/issues/58585 -- new tracker
2. https://tracker.ceph.com/issues/58256 -- fix merged to latest main
3. https://tracker.ceph.com/issues/58475
4. https://tracker.ceph.com/issues/57754 -- closed
5. https://tracker.ceph.com/issues/57546 -- fix is in testing

Details:
1. rook: failed to pull kubelet image - Ceph - Orchestrator
2. ObjectStore/StoreTestSpecificAUSize.SpilloverTest/2: Expected: (logger->get(l_bluefs_slow_used_bytes)) >= (16 * 1024 * 1024), actual: 0 vs 16777216 - Ceph - RADOS
3. test_dashboard_e2e.sh: Conflicting peer dependency: postcss@8.4.21 - Ceph - Mgr - Dashboard
4. test_envlibrados_for_rocksdb.sh: update-alternatives: error: alternative path /usr/bin/gcc-11 doesn't exist - Ceph - RADOS
5. rados/thrash-erasure-code: wait_for_recovery timeout due to "active+clean+remapped+laggy" pgs - Ceph - RADOS

@ljflores ljflores merged commit 65fb727 into ceph:main Jan 25, 2023
@tserong tserong deleted the wip-tserong-qa-crash-chown branch January 27, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljflores ljflores ljflores approved these changes

Assignees

No one assigned

Labels

core needs-qa tests wip-yuri2-testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tserong @ljflores @tchaikov