Skip to content

rgw : fix rgw create topic has no authentication bug#49297

Closed
BryceCao wants to merge 1 commit intoceph:mainfrom
BryceCao:wip-fix-rgw-create-topic-has-no-authentication
Closed

rgw : fix rgw create topic has no authentication bug#49297
BryceCao wants to merge 1 commit intoceph:mainfrom
BryceCao:wip-fix-rgw-create-topic-has-no-authentication

Conversation

@BryceCao
Copy link
Contributor

@BryceCao BryceCao commented Dec 7, 2022

Fixes: https://tracker.ceph.com/issues/58167
Signed-off-by: caolei cao.leilc@inspur.com

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@github-actions github-actions bot added the rgw label Dec 7, 2022
@cbodley cbodley requested a review from yuvalif December 7, 2022 16:26
@yuvalif
Copy link
Contributor

yuvalif commented Dec 7, 2022

@BryceCao thanks for your contribution!
however, your suggested implementation really break the authentication abstraction we have. it is introducing knowledge about specific ops to a generic mechanism on one hand, and spreading the logic of the ops across multiple unrelated files.
both will make any future maintenance diffcult.

@yuvalif
Copy link
Contributor

yuvalif commented Dec 8, 2022

@BryceCao I looked deeper into this issue, and to do that properly there is some refactoring needed in the way that we create the REST handler for topics, IAM and STS.
I would suggest that I do the refactoring first, and only then the fix to the above bug.

@yuvalif
Copy link
Contributor

yuvalif commented Dec 8, 2022

please see: #49335

@github-actions
Copy link

github-actions bot commented Jul 21, 2023

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Jul 21, 2023
@github-actions
Copy link

github-actions bot commented Aug 20, 2023

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!

@github-actions github-actions bot closed this Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuvalif yuvalif Awaiting requested review from yuvalif

Assignees

No one assigned

Labels

rgw stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BryceCao @yuvalif