Skip to content

qa: rbd_groups.sh: change interpreter to bash#49235

Merged
idryomov merged 1 commit intoceph:mainfrom
idryomov:wip-rbd-groups-bash
Dec 5, 2022
Merged

qa: rbd_groups.sh: change interpreter to bash#49235
idryomov merged 1 commit intoceph:mainfrom
idryomov:wip-rbd-groups-bash

Conversation

@idryomov
Copy link
Contributor

@idryomov idryomov commented Dec 4, 2022

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@idryomov
qa: rbd_groups.sh: change interpreter to bash
8f71273 
Commit e0da2a4 ("qa/workunits/rbd: Add test to list snapshots of
consistency group") added bash-specific syntax.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
@idryomov idryomov requested a review from a team as a code owner December 4, 2022 12:22
@idryomov
Copy link
Contributor Author

idryomov commented Dec 4, 2022

Fixes the following on Ubuntu where /bin/sh is dash:

2022-12-04T02:08:00.611 INFO:tasks.workunit.client.0.smithi197.stderr:+ check_snapshots_count_in_group test_consistency_group group_snap 10
2022-12-04T02:08:00.611 INFO:tasks.workunit.client.0.smithi197.stderr:+ local group_name=test_consistency_group
2022-12-04T02:08:00.612 INFO:tasks.workunit.client.0.smithi197.stderr:+ local snap_name=group_snap
2022-12-04T02:08:00.612 INFO:tasks.workunit.client.0.smithi197.stderr:+ local expected_count=10
2022-12-04T02:08:00.613 INFO:tasks.workunit.client.0.smithi197.stderr:+ local actual_count
2022-12-04T02:08:00.613 INFO:tasks.workunit.client.0.smithi197.stderr:+ list_snapshots test_consistency_group
2022-12-04T02:08:00.614 INFO:tasks.workunit.client.0.smithi197.stderr:+ local group_name=test_consistency_group+
2022-12-04T02:08:00.614 INFO:tasks.workunit.client.0.smithi197.stderr:+ rbd group snap list test_consistency_group
2022-12-04T02:08:00.615 INFO:tasks.workunit.client.0.smithi197.stderr:grep -c group_snap
2022-12-04T02:08:00.659 DEBUG:teuthology.orchestra.run:got remote process result: 127
2022-12-04T02:08:00.661 INFO:tasks.workunit.client.0.smithi197.stderr:+ actual_count=10
2022-12-04T02:08:00.661 INFO:tasks.workunit.client.0.smithi197.stderr:+ actual_count == expected_count
2022-12-04T02:08:00.661 INFO:tasks.workunit.client.0.smithi197.stderr:/home/ubuntu/cephtest/clone.client.0/qa/workunits/rbd/rbd_groups.sh: 176: actual_count: not found

@idryomov
Copy link
Contributor Author

idryomov commented Dec 4, 2022

jenkins test make check

@idryomov
Copy link
Contributor Author

idryomov commented Dec 5, 2022

jenkins test api

@idryomov
Copy link
Contributor Author

idryomov commented Dec 5, 2022

https://pulpito.ceph.com/dis-2022-12-04_10:47:36-rbd-wip-dis-testing-distro-default-smithi/

@idryomov idryomov merged commit 86b60eb into ceph:main Dec 5, 2022
@idryomov idryomov deleted the wip-rbd-groups-bash branch December 5, 2022 14:59
This was referenced Dec 5, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ajarr ajarr ajarr approved these changes

Assignees

No one assigned

Labels

cleanup rbd tests wip-dis-testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@idryomov @ajarr