qa/workunits/rados: skip running envlibrados rocksdb tests on ubuntu#49181
Merged
qa/workunits/rados: skip running envlibrados rocksdb tests on ubuntu#49181
Conversation
Member
Author
|
jenkins test api |
eb01cd1 to
5922d6d
Compare
fa2ed81 to
dc373c7
Compare
Member
Author
Member
Author
|
Both passed. |
Contributor
|
Shouldn't we just remove this test entirely if there aren't any actual users? |
Member
Author
@athanatos thoughts? We sort of talked about both options in the rados meeting, and I want to make sure I'm choosing the right one. |
14 tasks
dc373c7 to
b709236
Compare
Member
Author
|
Changed only to added more details to the commit message. |
This test passes on centos and rhel, but fails on ubuntu from an invalid pointer. Since the envlibrados rocksdb tests are experimental and don't have any actual users, we can just run them on rhel and centos. At the moment, the actual bug is not fully understood, but it was decided that fixing it is low priority, and removing the test from problematic distros is okay for the time being. This commit is considered a workaround to the actual issue. Related tracker: https://tracker.ceph.com/issues/57632 Signed-off-by: Laura Flores <lflores@redhat.com>
b709236 to
acc8c7e
Compare
neha-ojha
approved these changes
Jan 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test passes on centos and rhel, but fails on ubuntu from an
invalid pointer. Since the envlibrados rocksdb tests are experimental
and don't have any actual users, we can just run them on rhel and
centos.
At the moment, the actual bug is not fully understood, but it was
decided that fixing it is low priority, and removing the test from
problematic distros is okay for the time being. This commit
is considered a workaround to the actual issue.
Related tracker: https://tracker.ceph.com/issues/57632
Signed-off-by: Laura Flores lflores@redhat.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows