Skip to content

Wip nitzan fixing few rados/test.sh#49109

Merged
badone merged 5 commits intoceph:mainfrom
NitzanMordhai:wip-nitzan-fixing-few-rados/test.sh
Jan 26, 2023
Merged

Wip nitzan fixing few rados/test.sh#49109
badone merged 5 commits intoceph:mainfrom
NitzanMordhai:wip-nitzan-fixing-few-rados/test.sh

Conversation

@NitzanMordhai
Copy link
Contributor

@NitzanMordhai NitzanMordhai commented Nov 29, 2022 •
edited
Loading

We have few issues that keep pop while running rados/test.sh in https://tracker.ceph.com/issues/50042
Most of them related to watch timeout that causing tests to fail, some of them related to Segmentation fault during handle_error.

Some of the test will fail if #48641 is not present.

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@NitzanMordhai NitzanMordhai requested a review from a team as a code owner November 29, 2022 07:03
@rzarzynski rzarzynski requested a review from badone November 30, 2022 19:01
@NitzanMordhai
Copy link
Contributor Author

NitzanMordhai commented Dec 4, 2022

jenkins test make check

@NitzanMordhai
Copy link
Contributor Author

NitzanMordhai commented Dec 6, 2022

jenkins test windows

@NitzanMordhai
Copy link
Contributor Author

NitzanMordhai commented Dec 6, 2022

jenkins test make check arm64

@NitzanMordhai
Copy link
Contributor Author

NitzanMordhai commented Dec 12, 2022

jenkins test windows

@NitzanMordhai
Copy link
Contributor Author

NitzanMordhai commented Dec 12, 2022

jenkins test make check arm64

@rzarzynski
Copy link
Contributor

rzarzynski commented Dec 19, 2022

@badone: Hello Brad! Would you mind taking a look?

badone
badone approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@badone badone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks Nitzan.

tchaikov
tchaikov requested changes Dec 21, 2022
View reviewed changes
tchaikov
tchaikov reviewed Dec 21, 2022
View reviewed changes
tchaikov
tchaikov reviewed Dec 21, 2022
View reviewed changes
@NitzanMordhai
rados/test: adding debug message for forker task
9b1d1b1 
Adding debug message in case fork failed and output the error message.

Signed-off-by: Nitzan Mordechai <nmordec@redhat.com>
@NitzanMordhai
tests: ceph_test_rados_api_watch_notify LibRadosWatchNotify.AioWatchD…
0184c4b 
…elete reconnect

During test LibRadosWatchNotify.AioWatchDelete rados_watch_check can return error -102
if reconnect happened, in that case Broken pipe reconnect and -102 returned

Signed-off-by: Nitzan Mordechai <nmordech@redhat.com>
@NitzanMordhai
qa/suites/rados/verify: set watch timeout longer
8e76c17 
Some of the tests in Rados.sh can fail when trying to test
watch_list return size if we hit watch timeout.
increase the watch timeout for rados test

Fixes: https://tracker.ceph.com/issues/47025
Signed-off-by: Nitzan Mordechai <nmordec@redhat.com>
@NitzanMordhai NitzanMordhai force-pushed the wip-nitzan-fixing-few-rados/test.sh branch from 44a9668 to aa5b096 Compare December 21, 2022 19:03
tchaikov
tchaikov reviewed Dec 22, 2022
View reviewed changes
tchaikov
tchaikov reviewed Dec 22, 2022
View reviewed changes
tchaikov
tchaikov reviewed Dec 22, 2022
View reviewed changes
tchaikov
tchaikov reviewed Dec 22, 2022
View reviewed changes
@NitzanMordhai
test: Increase test alarm time
9f0dd47 
Waiting to watch_notify callback can take some time during heavy tests
that run under rados/test.sh for example.
Increasing the alarm time will allow the task to complete under those
conditions.

Fixing: https://tracker.ceph.com/issues/58130
Signed-off-by: Nitzan Mordechai <nmordec@redhat.com>
@NitzanMordhai
rados/test: cxx tests should be more readable
983a9ca 
Adding and changing temporary pools names prefix to match the
TestCase and test name to make debugging easier

Signed-off-by: Nitzan Mordechai <nmordec@redhat.com>
@NitzanMordhai NitzanMordhai force-pushed the wip-nitzan-fixing-few-rados/test.sh branch from aa5b096 to 983a9ca Compare December 22, 2022 06:08
@ljflores
Copy link
Member

ljflores commented Jan 26, 2023

Rados suite review: https://pulpito.ceph.com/?branch=wip-yuri-testing-2023-01-23-0926

Failures, unrelated:
1. https://tracker.ceph.com/issues/58587 -- new tracker
2. https://tracker.ceph.com/issues/58585
3. https://tracker.ceph.com/issues/58098 -- fix merged to latest main
4. https://tracker.ceph.com/issues/58256 -- fix merged to latest main
5. https://tracker.ceph.com/issues/57900
6. https://tracker.ceph.com/issues/58475
7. https://tracker.ceph.com/issues/58560

Details:
1. test_dedup_tool.sh: test_dedup_object fails when pool 'dedup_chunk_pool' does not exist - Ceph - RADOS
2. rook: failed to pull kubelet image - Ceph - Orchestrator
3. qa/workunits/rados/test_crash.sh: crashes are never posted - Ceph - RADOS
4. ObjectStore/StoreTestSpecificAUSize.SpilloverTest/2: Expected: (logger->get(l_bluefs_slow_used_bytes)) >= (16 * 1024 * 1024), actual: 0 vs 16777216 - Ceph - RADOS
5. mon/crush_ops.sh: mons out of quorum - Ceph - RADOS
6. test_dashboard_e2e.sh: Conflicting peer dependency: postcss@8.4.21 - Ceph - Mgr - Dashboard
7. test_envlibrados_for_rocksdb.sh failed to subscrib repo - Ceph

@badone badone merged commit d371237 into ceph:main Jan 26, 2023
This was referenced Jan 31, 2023
Merged
Merged
@cbodley cbodley mentioned this pull request Jun 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tchaikov tchaikov tchaikov approved these changes

@badone badone badone approved these changes

Assignees

No one assigned

Labels

core needs-qa tests wip-yuri-testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@NitzanMordhai @rzarzynski @ljflores @tchaikov @badone