Skip to content

quincy: cephadm: pin flake8 to 5.0.4#49059

Merged
adk3798 merged 3 commits intoceph:quincyfrom
idryomov:wip-cephadm-flake8-quincy
Dec 7, 2022
Merged

quincy: cephadm: pin flake8 to 5.0.4#49059
adk3798 merged 3 commits intoceph:quincyfrom
idryomov:wip-cephadm-flake8-quincy

Conversation

@idryomov
Copy link
Contributor

@idryomov idryomov commented Nov 25, 2022

Backport #49040 to quincy.

@tchaikov @idryomov
cephadm: pin flake8 to 5.0.4
532a978 
to workaround zheller/flake8-quotes#110
flake8 v5.0.4 is the last known-to-work flake8 before flake8 v6.0.0.

Fixes: https://tracker.ceph.com/issues/58069
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit ecb3fb1)
@tchaikov @idryomov
qa/tasks/cephfs: annotate variable without comment
3d974da 
to silence the warning like
```
flake8 run-test: commands[0] | flake8 --select=F,E9 --exclude=venv,.tox
./tasks/cephfs/test_full.py:6:5: F401 'typing.Optional' imported but unused
```

since we've migrated to python3.6 and up, there is no need to be
compatible with Python 2 anymore.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit 2413da8)
@tchaikov @idryomov
pybind/mgr: use annotation style without comment
f633c66 
* use annotation style without comment
* add noqa to import statement to prevent flake8 from complaining
  those which import typing modules

to silence the warnings like:

```
flake8 run-test: commands[0] | flake8 --config=tox.ini alerts balancer cephadm cli_api crash devicehealth diskprediction_local hello iostat localpool nfs orchestrator prometheus selftest
cephadm/schedule.py:5:1: F401 'typing.Callable' imported but unused
cephadm/schedule.py:8:1: F401 'ceph.deployment.service_spec.ServiceSpec' imported but unused
cephadm/tests/fixtures.py:17:1: F401 'orchestrator.OrchResult' imported but unused
orchestrator/module.py:4:1: F401 'typing.Set' imported but unused
orchestrator/module.py:17:1: F401 'ceph.deployment.inventory.Device' imported but unused
prometheus/module.py:17:1: F401 'typing.DefaultDict' imported but unused
6     F401 'typing.Callable' imported but unused
ERROR: InvocationError for command /home/jenkins-build/build/workspace/ceph-pull-requests/src/pybind/mgr/.tox/flake8/bin/flake8 --config=tox.ini alerts
```

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit 7894e7b)
@idryomov idryomov added this to the quincy milestone Nov 25, 2022
@idryomov idryomov requested a review from tchaikov November 25, 2022 12:03
@idryomov idryomov requested a review from a team as a code owner November 25, 2022 12:03
This was referenced Nov 25, 2022
Merged
Merged
@avanthakkar
Copy link
Contributor

avanthakkar commented Dec 1, 2022

jenkins test dashboard cephadm

@avanthakkar
Copy link
Contributor

avanthakkar commented Dec 1, 2022

jenkins test windows

This was referenced Dec 2, 2022
Merged
Merged
@ljflores ljflores mentioned this pull request Dec 6, 2022
Merged
14 tasks
@ljflores
Copy link
Member

ljflores commented Dec 6, 2022

@adk3798 does this need testing from Yuri, or are you already testing it in the orch suite?

@adk3798
Copy link
Contributor

adk3798 commented Dec 6, 2022

@adk3798 does this need testing from Yuri, or are you already testing it in the orch suite?

I have it an a partially completed orch suite run here https://pulpito.ceph.com/adking-2022-12-06_13:03:00-orch:cephadm-wip-adk3-testing-2022-12-05-1317-quincy-distro-default-smithi/

@adk3798
Copy link
Contributor

adk3798 commented Dec 6, 2022

@adk3798 does this need testing from Yuri, or are you already testing it in the orch suite?

I have it an a partially completed orch suite run here https://pulpito.ceph.com/adking-2022-12-06_13:03:00-orch:cephadm-wip-adk3-testing-2022-12-05-1317-quincy-distro-default-smithi/

only current failed test of which is just due to me not having made the quincy backport of #46539 yet

@ljflores
Copy link
Member

ljflores commented Dec 6, 2022

Ok. Let me know if it needs to go in a Quincy batch of Yuri's.

@adk3798
Copy link
Contributor

adk3798 commented Dec 7, 2022

https://pulpito.ceph.com/adking-2022-12-07_15:13:51-orch:cephadm-wip-adk3-testing-2022-12-05-1317-quincy-distro-default-smithi/

  • 2 failures in test_cephad task due to a master -> main change not having been backported yet (backport is now open but was not
  • 1 odd failure where test_nfs timed out, seemingly because of an issue with deployment of an mds service
2022-12-07T00:00:14.679 INFO:journalctl@ceph.mgr.a.smithi055.stdout:Dec 07 00:00:14 smithi055 conmon[119979]: 2022-12-07T00:00:14.397+0000 7fe452257700 -1 log_channel(cephadm) log [ERR] : Failed to apply mds.a spec MDSSpec.from_json(yaml.safe_load('''service_type: mds
2022-12-07T00:00:14.679 INFO:journalctl@ceph.mgr.a.smithi055.stdout:Dec 07 00:00:14 smithi055 conmon[119979]: service_id: a
2022-12-07T00:00:14.680 INFO:journalctl@ceph.mgr.a.smithi055.stdout:Dec 07 00:00:14 smithi055 conmon[119979]: service_name: mds.a
2022-12-07T00:00:14.680 INFO:journalctl@ceph.mgr.a.smithi055.stdout:Dec 07 00:00:14 smithi055 conmon[119979]: placement:
2022-12-07T00:00:14.680 INFO:journalctl@ceph.mgr.a.smithi055.stdout:Dec 07 00:00:14 smithi055 conmon[119979]:   count: 2
2022-12-07T00:00:14.680 INFO:journalctl@ceph.mgr.a.smithi055.stdout:Dec 07 00:00:14 smithi055 conmon[119979]: ''')): cephadm exited with an error code: 1, stderr: ERROR: Daemon not found: mds.a.smithi055.ystyid. See `cephadm ls`
2022-12-07T00:00:14.681 INFO:journalctl@ceph.mgr.a.smithi055.stdout:Dec 07 00:00:14 smithi055 conmon[119979]: Traceback (most recent call last):
2022-12-07T00:00:14.681 INFO:journalctl@ceph.mgr.a.smithi055.stdout:Dec 07 00:00:14 smithi055 conmon[119979]:   File "/usr/share/ceph/mgr/cephadm/serve.py", line 508, in _apply_all_services
2022-12-07T00:00:14.681 INFO:journalctl@ceph.mgr.a.smithi055.stdout:Dec 07 00:00:14 smithi055 conmon[119979]:     if self._apply_service(spec):
2022-12-07T00:00:14.681 INFO:journalctl@ceph.mgr.a.smithi055.stdout:Dec 07 00:00:14 smithi055 conmon[119979]:   File "/usr/share/ceph/mgr/cephadm/serve.py", line 837, in _apply_service
2022-12-07T00:00:14.682 INFO:journalctl@ceph.mgr.a.smithi055.stdout:Dec 07 00:00:14 smithi055 conmon[119979]:     self._remove_daemon(d.name(), d.hostname)
2022-12-07T00:00:14.682 INFO:journalctl@ceph.mgr.a.smithi055.stdout:Dec 07 00:00:14 smithi055 conmon[119979]:   File "/usr/share/ceph/mgr/cephadm/serve.py", line 1245, in _remove_daemon
2022-12-07T00:00:14.682 INFO:journalctl@ceph.mgr.a.smithi055.stdout:Dec 07 00:00:14 smithi055 conmon[119979]:     host, name, 'rm-daemon', args))
2022-12-07T00:00:14.683 INFO:journalctl@ceph.mgr.a.smithi055.stdout:Dec 07 00:00:14 smithi055 conmon[119979]:   File "/usr/share/ceph/mgr/cephadm/module.py", line 605, in wait_async
2022-12-07T00:00:14.683 INFO:journalctl@ceph.mgr.a.smithi055.stdout:Dec 07 00:00:14 smithi055 conmon[119979]:     return self.event_loop.get_result(coro)
2022-12-07T00:00:14.683 INFO:journalctl@ceph.mgr.a.smithi055.stdout:Dec 07 00:00:14 smithi055 conmon[119979]:   File "/usr/share/ceph/mgr/cephadm/ssh.py", line 48, in get_result
2022-12-07T00:00:14.683 INFO:journalctl@ceph.mgr.a.smithi055.stdout:Dec 07 00:00:14 smithi055 conmon[119979]:     return asyncio.run_coroutine_threadsafe(coro, self._loop).result()
2022-12-07T00:00:14.684 INFO:journalctl@ceph.mgr.a.smithi055.stdout:Dec 07 00:00:14 smithi055 conmon[119979]:   File "/lib64/python3.6/concurrent/futures/_base.py", line 432, in result
2022-12-07T00:00:14.684 INFO:journalctl@ceph.mgr.a.smithi055.stdout:Dec 07 00:00:14 smithi055 conmon[119979]:     return self.__get_result()
2022-12-07T00:00:14.684 INFO:journalctl@ceph.mgr.a.smithi055.stdout:Dec 07 00:00:14 smithi055 conmon[119979]:   File "/lib64/python3.6/concurrent/futures/_base.py", line 384, in __get_result
2022-12-07T00:00:14.684 INFO:journalctl@ceph.mgr.a.smithi055.stdout:Dec 07 00:00:14 smithi055 conmon[119979]:     raise self._exception
2022-12-07T00:00:14.685 INFO:journalctl@ceph.mgr.a.smithi055.stdout:Dec 07 00:00:14 smithi055 conmon[119979]:   File "/usr/share/ceph/mgr/cephadm/serve.py", line 1391, in _run_cephadm
2022-12-07T00:00:14.685 INFO:journalctl@ceph.mgr.a.smithi055.stdout:Dec 07 00:00:14 smithi055 conmon[119979]:     f'cephadm exited with an error code: {code}, stderr: {err}')
2022-12-07T00:00:14.685 INFO:journalctl@ceph.mgr.a.smithi055.stdout:Dec 07 00:00:14 smithi055 conmon[119979]: orchestrator._interface.OrchestratorError: cephadm exited with an error code: 1, stderr: ERROR: Daemon not found: mds.a.smithi055.ystyid. See `cephadm ls`

issue was not reproducible, other two test_nfs tests in the run + 5 reruns of the exact test that failed all passed (https://pulpito.ceph.com/adking-2022-12-07_15:13:51-orch:cephadm-wip-adk3-testing-2022-12-05-1317-quincy-distro-default-smithi/).

Overall, nothing here that should block merging I think. First two are expected and last failure looks unrelated to PRs in the run (and obviously doesn't happen in most runs). Will watch in case I see it again.

@adk3798 adk3798 merged commit 2a41a65 into ceph:quincy Dec 7, 2022
@idryomov idryomov deleted the wip-cephadm-flake8-quincy branch December 7, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tchaikov tchaikov tchaikov approved these changes

@adk3798 adk3798 adk3798 approved these changes

Assignees

No one assigned

Labels

cephadm cephfs Ceph File System monitoring needs-qa orchestrator pybind quincy-batch-1 tests wip-adk3-testing

Projects

None yet

Milestone

quincy

Development

Successfully merging this pull request may close these issues.

5 participants

@idryomov @avanthakkar @ljflores @adk3798 @tchaikov