Skip to content

crimson/osd: Support Pool EIO flag#49029

Merged
tchaikov merged 4 commits intoceph:mainfrom
Matan-B:wip-matanb-EIO-flag
Nov 24, 2022
Merged

crimson/osd: Support Pool EIO flag#49029
tchaikov merged 4 commits intoceph:mainfrom
Matan-B:wip-matanb-EIO-flag

Conversation

@Matan-B
Copy link
Contributor

@Matan-B Matan-B commented Nov 23, 2022 •
edited
Loading 

$ CRIMSON_COMPAT=true RBD_FEATURES= bin/ceph_test_rados_api_aio_pp 
  --gtest_filter="LibRadosAio.*PoolEIOFlag" 
Running main() from gmock_main.cc
Note: Google Test filter = LibRadosAio.*PoolEIOFlag
[==========] Running 2 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 2 tests from LibRadosAio 
[ RUN      ] LibRadosAio.SimplePoolEIOFlag
[       OK ] LibRadosAio.SimplePoolEIOFlag (15634 ms) 
[ RUN      ] LibRadosAio.PoolEIOFlag  
setting pool EIO
waiting for 99,100
max_success 98, min_failed 99
[       OK ] LibRadosAio.PoolEIOFlag (16008 ms) 
[----------] 2 tests from LibRadosAio (31642 ms total)
[----------] Global test environment tear-down 
[==========] 2 tests from 1 test suite ran. (31642 ms total)  
[  PASSED  ] 2 tests.

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@Matan-B
test/librados/aio_cxx: Fix PoolEIOFlag test
d420acd 
* wait_for_complete is added before getting the return value.

* for loop iteration limit is added to avoid infinite run.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B
test/librados/aio_cxx: Simple PoolEIOFlag is added
fbd177d 
Useful for debugging.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B
crimson/osd/osd_operations/client_request: Support FLAG_EIO
b3ecd37 
See 5ac9f52

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B Matan-B force-pushed the wip-matanb-EIO-flag branch from a555d9e to b3ecd37 Compare November 23, 2022 15:55
@Matan-B Matan-B marked this pull request as ready for review November 23, 2022 16:03
@Matan-B Matan-B requested a review from a team as a code owner November 23, 2022 16:03
tchaikov
tchaikov reviewed Nov 23, 2022
View reviewed changes
@Matan-B
test/librados/aio_cxx: use fmt formatting
76e4c5d 
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B Matan-B force-pushed the wip-matanb-EIO-flag branch from bb966dd to 76e4c5d Compare November 23, 2022 17:28
@Matan-B Matan-B requested a review from tchaikov November 23, 2022 17:29
@tchaikov
Copy link
Contributor

tchaikov commented Nov 23, 2022

jenkins test make check

liu-chunmei
liu-chunmei approved these changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@liu-chunmei liu-chunmei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tchaikov
Copy link
Contributor

tchaikov commented Nov 24, 2022

jenkins test make check

3 similar comments
@tchaikov
Copy link
Contributor

tchaikov commented Nov 24, 2022

jenkins test make check

@tchaikov
Copy link
Contributor

tchaikov commented Nov 24, 2022

jenkins test make check

@tchaikov
Copy link
Contributor

tchaikov commented Nov 24, 2022

jenkins test make check

@tchaikov tchaikov merged commit 962fe28 into ceph:main Nov 24, 2022
@tchaikov
Copy link
Contributor

tchaikov commented Nov 25, 2022

sorry. i should have run the change against qa tests before merging it.

@Matan-B Matan-B mentioned this pull request Nov 27, 2022
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tchaikov tchaikov tchaikov approved these changes

@liu-chunmei liu-chunmei liu-chunmei approved these changes

Assignees

No one assigned

Labels

crimson tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Matan-B @tchaikov @liu-chunmei