[DNM]quincy:mon/OSDMonitor: Added extra check before mon.go_recovery_stretch_mode()#48802
Closed
kamoltat wants to merge 3 commits intoceph:quincyfrom
Closed
[DNM]quincy:mon/OSDMonitor: Added extra check before mon.go_recovery_stretch_mode()#48802kamoltat wants to merge 3 commits intoceph:quincyfrom
kamoltat wants to merge 3 commits intoceph:quincyfrom
Conversation
neha-ojha
approved these changes
Nov 8, 2022
Member
Author
|
#47340 |
Added bug reproducer for https://bugzilla.redhat.com/show_bug.cgi?id=2104207 Added more logs in MON. Signed-off-by: Kamoltat <ksirivad@redhat.com> (cherry picked from commit 62fe3cb)
Problem: There are certain scenarios in degraded stretched cluster where will try to go into the function ``Monitor::go_recovery_stretch_mode()`` that will lead to a `ceph_assert`. Solution: Make sure ``dead_mon_buckets.size() == 0`` in ``OSDMonitor:update_from_paxos()`` before going into ``Monitor::go_recovery_stretch_mode()``. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2104207 Signed-off-by: Kamoltat <ksirivad@redhat.com> (cherry picked from commit d95c41a)
Signed-off-by: Kamoltat <ksirivad@redhat.com>
3392f14 to
02b0579
Compare
Member
Author
|
PR moved to #51413. Closing the PR since it is not relevant anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
There are certain scenarios in degraded
stretched cluster where will try to
go into the
function
Monitor::go_recovery_stretch_mode()that will lead to a
ceph_assert.Solution:
Make sure
dead_mon_buckets.size() == 0in
OSDMonitor:update_from_paxos()before going into
Monitor::go_recovery_stretch_mode().Fixes:
https://tracker.ceph.com/issues/57017
Backporting relevant commits from main PR:
#47340
Signed-off-by: Kamoltat ksirivad@redhat.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows