Skip to content

common: add a config option for jaeger agent port#48709

Merged
yuvalif merged 1 commit intoceph:mainfrom
yanghonggang:yhg-jaeger-port
Feb 20, 2023
Merged

common: add a config option for jaeger agent port#48709
yuvalif merged 1 commit intoceph:mainfrom
yanghonggang:yhg-jaeger-port

Conversation

@yanghonggang
Copy link
Contributor

@yanghonggang yanghonggang commented Nov 2, 2022 •
edited
Loading

jaeger-agent port is changed from 6831 to 6799 in commit 9d7280c, which lead to "vstart.sh ... --jaeger" can't work. In order to fix this problem, a config option jaeger_agent_port is added and in vstart.sh the default value of jaeger_agent_port is set to 6831.

Signed-off-by: Yang Honggang yanghonggang_yewu@cmss.chinamobile.com

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@github-actions github-actions bot added the common label Nov 2, 2022
@yanghonggang
Copy link
Contributor Author

yanghonggang commented Nov 7, 2022

@zenomri @ideepika please help to review

zenomri
zenomri reviewed Nov 8, 2022
View reviewed changes
@zenomri
Copy link

zenomri commented Nov 8, 2022

@yanghonggang Thanks for the PR!

@zenomri zenomri requested a review from yuvalif November 8, 2022 10:13
@yanghonggang yanghonggang requested review from zenomri and removed request for yuvalif November 9, 2022 06:13
@yanghonggang
Copy link
Contributor Author

yanghonggang commented Nov 10, 2022

ping @zenomri @yuvalif

@yuvalif yuvalif self-requested a review November 14, 2022 17:04
tchaikov
tchaikov reviewed Nov 14, 2022
View reviewed changes
@yanghonggang
common: add a config option for jaeger agent port
517339d 
jaeger-agent port is changed from 6831 to 6799 in commit 9d7280c,
which lead to "vstart.sh ... --jaeger" can't work.
In order to fix this problem, a config option jaeger_agent_port is added
and in vstart.sh the default value of jaeger_agent_port is set to 6831.

Signed-off-by: Yang Honggang <yanghonggang_yewu@cmss.chinamobile.com>
@yanghonggang
Copy link
Contributor Author

yanghonggang commented Nov 15, 2022

jenkins test make check

@yanghonggang
Copy link
Contributor Author

yanghonggang commented Jan 20, 2023

ping @yuvalif

@yuvalif
Copy link
Contributor

yuvalif commented Jan 20, 2023 •
edited
Loading

ping @yuvalif

the shaman/tethology systems are now functional.
once this PR pass regression I will merge

@yuvalif
Copy link
Contributor

yuvalif commented Feb 16, 2023

teuthology results has 8 fialures:

  • in s3test:
s3tests_boto3/functional/test_iam.py::test_deny_bucket_actions_in_user_policy
s3tests_boto3/functional/test_iam.py::test_deny_object_actions_in_user_policy
s3tests_boto3/functional/test_iam.py::test_deny_multipart_actions_in_user_policy
s3tests_boto3/functional/test_iam.py::test_allow_tagging_actions_in_user_policy
s3tests_boto3/functional/test_iam.py::test_deny_tagging_actions_in_user_policy
s3tests_boto3/functional/test_iam.py::test_verify_conflicting_user_policy_statements
s3tests_boto3/functional/test_iam.py::test_verify_conflicting_user_policies
s3tests_boto3/functional/test_s3.py::test_lifecycle_expiration_header_and_tags_head
s3tests_boto3/functional/test_iam.py::test_deny_bucket_actions_in_user_policy
s3tests_boto3/functional/test_iam.py::test_allow_object_actions_in_user_policy
  • in lifecycle:
s3tests_boto3/functional/test_s3.py::test_lifecycle_expiration_header_tags_head
s3tests_boto3/functional/test_s3.py::test_lifecycle_expiration_header_and_tags_head
  • in multisite there is a crash. backtrace is not very helpful:
 ceph version 18.0.0-2202-geab2837b (eab2837b51fd107d0ea9d17b3120ab5aebb52876) reef (dev)
 1: /lib64/libpthread.so.0(+0x12cf0) [0x7fc541763cf0]
 2: gsignal()
 3: abort()
 4: /lib64/libstdc++.so.6(+0x9009b) [0x7fc540eaa09b]
 5: /lib64/libstdc++.so.6(+0x9653c) [0x7fc540eb053c]
 6: /lib64/libstdc++.so.6(+0x95559) [0x7fc540eaf559]
 7: __gxx_personality_v0()
 8: /lib64/libgcc_s.so.1(+0x10b03) [0x7fc540890b03]
 9: _Unwind_Resume()
 10: radosgw(+0x5069ae) [0x55c6b70289ae]
 11: radosgw(+0x639b0d) [0x55c6b715bb0d]
 12: /lib64/libstdc++.so.6(+0xc2ba3) [0x7fc540edcba3]
 13: /lib64/libpthread.so.0(+0x81ca) [0x7fc5417591ca]
 14: clone()

more details here

  • also, in multisite following tests fail:
test_version_suspended_incremental_sync
test_encrypted_object_sync
test_bucket_reshard_index_log_trim
test_zap_init_bucket_sync_run
test_resharded_bucket_incremental_sync_latest_after_data_sync_init
test_resharded_bucket_incremental_sync_oldest_after_data_sync_init

except the first failure it looks like the rest of the failures are due to an RGW crash, but there is no crash trace in teuthology

s3tests_boto3/functional/test_s3.py::test_sse_kms_multipart_upload - b...
s3tests_boto3/functional/test_s3.py::test_sse_kms_multipart_invalid_chunks_1

This was referenced Feb 16, 2023
Merged
Merged
@yuvalif
Copy link
Contributor

yuvalif commented Feb 20, 2023

all above failures are know:

@yuvalif yuvalif merged commit 75fcae6 into ceph:main Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tchaikov tchaikov tchaikov left review comments

@yuvalif yuvalif yuvalif approved these changes

+1 more reviewer

@zenomri zenomri zenomri approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

common needs-qa wip-yuval-testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yanghonggang @zenomri @yuvalif @tchaikov