cls/rbd: update last_read in group::snap_list #48549
Conversation
|
@idryomov will it be possible for you to schedule the lab tests for this PR, please? Thanks! |
idryomov
left a comment
There was a problem hiding this comment.
LGTM, some nits on the test case
|
@idryomov Thanks for the review Ilya, addressed your review comments now. |
trociny
left a comment
There was a problem hiding this comment.
LGTM
You could add the "list overflow" test to src/test/cls_rbd/test_cls_rbd.cc. We already did it for mirror_image_status_list, when fixed a similar issue. Though I don't mind if you don't, because we do not have such tests for other list functions.
Let's add it for this one since it has lingered for so long it took a user to stumble upon this... |
|
Please fold the fourth commit into the first one (so that the test is added together with the code change) and rename the third commit to "test/cls_rbd: delete unused image_id variable". |
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Problem:
`rbd group snap ls` shows 1025 records after creating 65 snaps
with `rbd group snap create`
$ for i in {1..65}; do rbd group snap create test_group@group_snap$i; done
$ rbd group snap ls test_group | wc -l
1025
Solution:
update last_read after getting RBD_MAX_KEYS_READ with cls_cxx_map_get_vals.
Fixes: https://tracker.ceph.com/issues/57066
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
|
One process-related nit: don't rebase when force-pushing a new version of the PR unless the rebase is necessary to pick up a relevant change or dependency that just showed up main. Keep the base commit the same -- this makes diffing much easier. Otherwise LGTM! |
cls/rbd: update last read in group::snap_list
Problem:
rbd group snap lsshows 1025 records after creating 65 snapswith
rbd group snap create$ for i in {1..65}; do rbd group snap create test_group@group_snap$i; done
$ rbd group snap ls test_group | wc -l
1025
Solution:
update last_read after getting RBD_MAX_KEYS_READ with cls_cxx_map_get_vals.
Fixes: https://tracker.ceph.com/issues/57066
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows