mgr/dashboard: refactor dashboard cephadm e2e tests#48163
Merged
nizamial09 merged 2 commits intoceph:mainfrom Oct 11, 2022
Merged
mgr/dashboard: refactor dashboard cephadm e2e tests#48163nizamial09 merged 2 commits intoceph:mainfrom
nizamial09 merged 2 commits intoceph:mainfrom
Conversation
241ddba to
c5ced18
Compare
14 tasks
c5ced18 to
04cc9a2
Compare
Member
Author
|
jenkins test dashboard |
Merged
14 tasks
Member
Author
aaSharma14
approved these changes
Sep 30, 2022
Member
Author
|
teuthology passed ✔️ |
Fixes: https://tracker.ceph.com/issues/57511 Signed-off-by: Nizamudeen A <nia@redhat.com>
This reverts commit b79e2a6. Signed-off-by: Nizamudeen A <nia@redhat.com>
f73ff65 to
82d2ac1
Compare
Member
Author
|
jenkins test make check |
Member
Author
|
jenkins test dashboard |
Member
Author
|
Jenkins test make check |
Member
Author
|
Jenkins test dashboard |
Member
Author
|
merging this to fix the cephadm e2e ci. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'll be reverting the PR to select/unselect datatables: #45313
I moved the code for changing the alertmanager_api_host, prometheus_api_host and grafana_api_url from the tests to the script to reduce the complexity of the tests. We are not actually testing anything there just making sure the environment is ready and the urls are okay. Because by default, these urls are set with fqdn and kcli env has issues with the fqdns.
Also by doing this it reduces some 404 errors coming from the node-exporter and prometheus so that the tests won't be affected by it.
In addition to this I reduced the count of node-exporter to 2 before starting the test. Its because, if we try to drain a host that has a node-exporter in it, that will cause a 404 error momentarily and that will cause the cypress to fail again. By positioning it into the script itself, this issue won't be there.
There used to appear an ExpressionChangedAfterChecked error in the service-daemon-list component because of the relativeDate pipe. And I did some searching and its a known issue with the date pipes . The good thing is that this will only happen in the developer environment. The easiest and proper way to catch this is to manually do the changeDetection which I done using a timeout.
There are some minor cleanups too where I do a proper cleanup by deleting the pool as well as the
.kclifolder. Its to prevent errors likefedora36 image not found and it causes the vms to not startand that will make the test to hang there. The downside of doing this is that everytime the test needs to run in an environment it'll need to download the fedora36 image, but it'll make the test a bit more foolproof.Fixes: https://tracker.ceph.com/issues/57511
Fixes: https://tracker.ceph.com/issues/57386
Signed-off-by: Nizamudeen A nia@redhat.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows