Skip to content

mgr/dashboard: refactor dashboard cephadm e2e tests#48163

Merged
nizamial09 merged 2 commits intoceph:mainfrom
rhcs-dashboard:refactor-cephadm-e2e
Oct 11, 2022
Merged

mgr/dashboard: refactor dashboard cephadm e2e tests#48163
nizamial09 merged 2 commits intoceph:mainfrom
rhcs-dashboard:refactor-cephadm-e2e

Conversation

@nizamial09
Copy link
Member

@nizamial09 nizamial09 commented Sep 19, 2022

I'll be reverting the PR to select/unselect datatables: #45313

I moved the code for changing the alertmanager_api_host, prometheus_api_host and grafana_api_url from the tests to the script to reduce the complexity of the tests. We are not actually testing anything there just making sure the environment is ready and the urls are okay. Because by default, these urls are set with fqdn and kcli env has issues with the fqdns.
Also by doing this it reduces some 404 errors coming from the node-exporter and prometheus so that the tests won't be affected by it.

In addition to this I reduced the count of node-exporter to 2 before starting the test. Its because, if we try to drain a host that has a node-exporter in it, that will cause a 404 error momentarily and that will cause the cypress to fail again. By positioning it into the script itself, this issue won't be there.

There used to appear an ExpressionChangedAfterChecked error in the service-daemon-list component because of the relativeDate pipe. And I did some searching and its a known issue with the date pipes . The good thing is that this will only happen in the developer environment. The easiest and proper way to catch this is to manually do the changeDetection which I done using a timeout.

There are some minor cleanups too where I do a proper cleanup by deleting the pool as well as the .kcli folder. Its to prevent errors like fedora36 image not found and it causes the vms to not start and that will make the test to hang there. The downside of doing this is that everytime the test needs to run in an environment it'll need to download the fedora36 image, but it'll make the test a bit more foolproof.

Fixes: https://tracker.ceph.com/issues/57511
Fixes: https://tracker.ceph.com/issues/57386
Signed-off-by: Nizamudeen A nia@redhat.com

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@nizamial09 nizamial09 requested a review from a team as a code owner September 19, 2022 08:46
@nizamial09 nizamial09 requested review from Pegonzal and torchiaf and removed request for a team September 19, 2022 08:46
@nizamial09 nizamial09 force-pushed the refactor-cephadm-e2e branch 22 times, most recently from 241ddba to c5ced18 Compare September 23, 2022 05:20
@nizamial09
Copy link
Member Author

jenkins test dashboard

@nizamial09
Copy link
Member Author

nizamial09 commented Sep 30, 2022

shaman passed ✔️
teuthology failed

@nizamial09
Copy link
Member Author

teuthology passed ✔️

This reverts commit b79e2a6.

Signed-off-by: Nizamudeen A <nia@redhat.com>
@nizamial09
Copy link
Member Author

jenkins test make check

@nizamial09
Copy link
Member Author

jenkins test dashboard

@nizamial09
Copy link
Member Author

Jenkins test make check

@nizamial09
Copy link
Member Author

Jenkins test dashboard

@nizamial09
Copy link
Member Author

merging this to fix the cephadm e2e ci.

@nizamial09 nizamial09 merged commit 2534d4e into ceph:main Oct 11, 2022
@nizamial09 nizamial09 deleted the refactor-cephadm-e2e branch October 11, 2022 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants