osd: verify missing version check assert change#48088
osd: verify missing version check assert change#48088NitzanMordhai wants to merge 1 commit intoceph:mainfrom
Conversation
Verify missing logs during read_log_and_missing will verify the missing deleted version, usually it will be MIN, but there are some cases where it will have prior version. Fixes: https://tracker.ceph.com/issues/45702 Signed-off-by: Nitzan Mordechai <nmordech@redhat.com>
e847a84 to
aa30873
Compare
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
|
This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution! |
|
@rzarzynski @NitzanMordhai Under what conditions can it be prior_verison? |
@athanatos if I remember correctly, that happens only when debug_verify_stored_missing, and pretty rarely, the thrasher is on and when the osd starts the missing vector can have a previous version of the deleted object. |
|
That's when the assert happens, yes. My question is how a missing item like that is created. If the item itself is a bug, than expanding the assert would be a mistake. |
|
@athanatos can you please check my recent note in the tracker? https://tracker.ceph.com/issues/45702?next_issue_id=67471&prev_issue_id=54580#note-27 |
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
|
This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution! |
|
Reopening. @athanatos, could you please see the @NitzanMordhai's #48088 (comment)? |
@rzarzynski, after checking the latest incident and rethinking @athanatos's comments, I agree that my solution is not the correct one. We have another bug, and I think that I have enough to fix it. I'll close that PR and open a new one with a different solution. |
|
created new PR for that issue: #62705 62705 |
Verify missing logs during read_log_and_missing will verify the missing deleted version, usually it will be MIN, but there are some cases where it will have prior version.
Fixes: https://tracker.ceph.com/issues/45702
Signed-off-by: Nitzan Mordechai nmordech@redhat.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows