Skip to content

quincy: common/ceph_context: leak some memory fail to show in valgrind#47933

Merged
yuriw merged 1 commit intoceph:quincyfrom
rzarzynski:wip-57346-quincy
Oct 6, 2022
Merged

quincy: common/ceph_context: leak some memory fail to show in valgrind#47933
yuriw merged 1 commit intoceph:quincyfrom
rzarzynski:wip-57346-quincy

Conversation

@rzarzynski
Copy link
Contributor

@rzarzynski rzarzynski commented Sep 2, 2022

backport tracker: https://tracker.ceph.com/issues/57346

backport of #47802
parent tracker: https://tracker.ceph.com/issues/57165

this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh

@NitzanMordhai @rzarzynski
common/ceph_context: leak some memory fail to show in valgrind
a8c6178 
GCC 20 memory optimization broke the memory leak for testing.

Fixes:https://tracker.ceph.com/issues/57165
Signed-off-by: Nitzan Mordechai <nmordec@redhat.com>
(cherry picked from commit fc21669)
@rzarzynski rzarzynski added this to the quincy milestone Sep 2, 2022
@NitzanMordhai
Copy link
Contributor

NitzanMordhai commented Sep 7, 2022

jenkins test make check

@neha-ojha neha-ojha added the core label Sep 13, 2022
@ljflores
Copy link
Member

ljflores commented Sep 27, 2022 •
edited
Loading

@rzarzynski @NitzanMordhai this test run still hit an "expected valgrind issues and found none" failure. Strangely, it passed in the rerun.
http://pulpito.front.sepia.ceph.com/yuriw-2022-09-23_20:38:59-rados-wip-yuri6-testing-2022-09-23-1008-quincy-distro-default-smithi/7042504/

Can either of you investigate?

Both test runs are on this link: http://pulpito.front.sepia.ceph.com/?branch=wip-yuri6-testing-2022-09-23-1008-quincy
Also, here is the Trello: https://trello.com/c/iEU3xOhe/1638-wip-yuri6-testing-2022-09-23-1008-quincy

@ljflores
Copy link
Member

ljflores commented Sep 29, 2022

@NitzanMordhai I saw your comment about the valgrind failure on the trello:

We failed here due to test didn't start yet, we are waiting for all the osds to come up but osd.0 didn't start yet. So we didn't even issue the leak_some_memory command.

Is this a separate issue then? Or something wrong with the PR? Let me know, and I can have the PR retested if needed. @yuriw has added the TESTED label for now to signal that this has gone through a round of testing.

@ljflores
Copy link
Member

ljflores commented Sep 29, 2022 •
edited
Loading

This is the current rados suite review by the way:

http://pulpito.front.sepia.ceph.com/?branch=wip-yuri6-testing-2022-09-23-1008-quincy

One failure to be investigated:
1. There was an instance of https://tracker.ceph.com/issues/57165 in the test run, but this PR is meant to fix that.

Failures, unrelated:
1. https://tracker.ceph.com/issues/57386
2. https://tracker.ceph.com/issues/57311
3. https://tracker.ceph.com/issues/56951

Details:
1. cephadm/test_dashboard_e2e.sh: Expected to find content: '/^foo$/' within the selector: 'cd-modal .badge' but never did - Ceph - Mgr - Dashboard
2. rook: ensure CRDs are installed first - Ceph - Orchestrator
3. rook/smoke: Updating cephclusters/rook-ceph is forbidden - Ceph - Orchestrator

@yuriw yuriw merged commit 45530eb into ceph:quincy Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neha-ojha neha-ojha neha-ojha approved these changes

@NitzanMordhai NitzanMordhai NitzanMordhai approved these changes

Assignees

No one assigned

Labels

common core needs-qa ready-to-merge TESTED

Projects

None yet

Milestone

quincy

Development

Successfully merging this pull request may close these issues.

5 participants

@rzarzynski @NitzanMordhai @ljflores @neha-ojha @yuriw