Skip to content

examples/librados: Compile with c++20 on Ubuntu#47900

Merged
ljflores merged 1 commit intoceph:mainfrom
Matan-B:wip-matanb-librados-20
Sep 21, 2022
Merged

examples/librados: Compile with c++20 on Ubuntu#47900
ljflores merged 1 commit intoceph:mainfrom
Matan-B:wip-matanb-librados-20

Conversation

@Matan-B
Copy link
Contributor

@Matan-B Matan-B commented Sep 1, 2022 •
edited
Loading

Kudos to @jdurgin

Fixes: https://tracker.ceph.com/issues/57163

Verified fix on Ubuntu, CentOS and RHEL.

https://pulpito.ceph.com/matan-2022-09-05_08:24:48-rados:singleton-nomsgr-main-distro-default-smithi/
Tested against fork: Matan-B@dc9cb4a

Signed-off-by: Matan Breizman mbreizma@redhat.com

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@Matan-B Matan-B requested a review from a team as a code owner September 1, 2022 13:33
ronen-fr
ronen-fr reviewed Sep 1, 2022
View reviewed changes
ronen-fr
ronen-fr reviewed Sep 1, 2022
View reviewed changes
@Matan-B Matan-B force-pushed the wip-matanb-librados-20 branch from 4550ebd to 7d9741b Compare September 5, 2022 08:50
@ljflores
Copy link
Member

ljflores commented Sep 6, 2022

This solution makes a whole lot of sense!

@ljflores
Copy link
Member

ljflores commented Sep 6, 2022

We should test it with rhel and centos also to be sure everything's working. I don't see why it wouldn't, but just to say that it was tested from all angles.

@ljflores
Copy link
Member

ljflores commented Sep 6, 2022

Also, another test that was affected by invalid pointer was http://pulpito.front.sepia.ceph.com/kchai-2022-08-23_13:19:39-rados-wip-kefu-testing-2022-08-22-2243-distro-default-smithi/6987883/.

For that, I think we'll need to make some adjustments to this file: https://github.com/ceph/ceph/blob/main/qa/workunits/rados/test_envlibrados_for_rocksdb.sh

@rzarzynski
Copy link
Contributor

rzarzynski commented Sep 12, 2022

jenkins test make check

@Matan-B
Copy link
Contributor Author

Matan-B commented Sep 18, 2022

@ljflores @yuriw
Regarding yuri6-testing, this test should still fail in teuthology until merged.
I had to manually adjust the DL_PREFIX used by the test for pulling the examples/librados dir (See Matan-B@dc9cb4a - which is not part of this PR).
Meaning, we expect to pass only after merging, since we use main's examples/librados for this test.

@Matan-B
Copy link
Contributor Author

Matan-B commented Sep 19, 2022 •
edited
Loading

Let's take it out of this PR scope?

@Matan-B Matan-B force-pushed the wip-matanb-librados-20 branch 2 times, most recently from d0b4a9b to a633636 Compare September 19, 2022 13:12
@Matan-B
Copy link
Contributor Author

Matan-B commented Sep 19, 2022

Ubuntu:
https://pulpito.ceph.com/matan-2022-09-19_11:52:23-rados:singleton-nomsgr-main-distro-default-smithi/
Centos:
https://pulpito.ceph.com/matan-2022-09-19_12:45:07-rados:singleton-nomsgr-main-distro-default-smithi/
RHEL:
https://pulpito.ceph.com/matan-2022-09-19_12:45:32-rados:singleton-nomsgr-main-distro-default-smithi/

@Matan-B Matan-B removed the DNM label Sep 19, 2022
@Matan-B Matan-B changed the title examples: Compile with c++20 examples/librados: Compile with c++20 on Ubuntu Sep 19, 2022
@Matan-B
examples: Compile with c++20
be83865 
This change will apply to ubuntu only.
Fixes: https://tracker.ceph.com/issues/57163

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B Matan-B force-pushed the wip-matanb-librados-20 branch from a633636 to be83865 Compare September 19, 2022 13:18
@Matan-B Matan-B requested a review from ljflores September 19, 2022 13:19
@Matan-B Matan-B removed the needs-qa label Sep 19, 2022
ljflores
ljflores approved these changes Sep 21, 2022
View reviewed changes
Copy link
Member

@ljflores ljflores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Matan-B since the rocksdb test is a different issue, let's copy that one to a different Tracker. Otherwise, LGTM!

@ljflores ljflores merged commit 80893b4 into ceph:main Sep 21, 2022
@rzarzynski rzarzynski mentioned this pull request Feb 21, 2023
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljflores ljflores ljflores approved these changes

@ronen-fr ronen-fr Awaiting requested review from ronen-fr

@jdurgin jdurgin Awaiting requested review from jdurgin

Assignees

No one assigned

Labels

core tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Matan-B @ljflores @rzarzynski @ronen-fr