[DNM] pacific: osd/PeeringState: fix missed recheck_readable from laggy#47899
Closed
amathuria wants to merge 2 commits intoceph:pacificfrom
Closed
[DNM] pacific: osd/PeeringState: fix missed recheck_readable from laggy#47899amathuria wants to merge 2 commits intoceph:pacificfrom
amathuria wants to merge 2 commits intoceph:pacificfrom
Conversation
We should not have duplicated OSD ID in `acting`. So the loop would execute once anyway. Signed-off-by: 胡玮文 <huww98@outlook.com> (cherry picked from commit 9337fa6)
Previously, the first `pg_lease_ack_t` after becoming laggy would not trigger `recheck_readable`. However, every other ack would trigger it. The logic is inverted, causing unnecessarily long laggy PG state. Fixes: 3bb8a72 (osd: requeue ops when PG is no longer laggy) Fixes: https://tracker.ceph.com/issues/53806 Signed-off-by: 胡玮文 <huww98@outlook.com> (cherry picked from commit caeca39)
neha-ojha
approved these changes
Sep 1, 2022
Contributor
Author
|
jenkins test make check |
Contributor
Author
|
jenkins test api |
Contributor
Author
|
http://pulpito.front.sepia.ceph.com/?branch=wip-yuri5-testing-2022-09-06-1334-pacific Failures, unrelated:
Details:
|
ljflores
requested changes
Sep 14, 2022
Member
ljflores
left a comment
There was a problem hiding this comment.
We found that this PR has caused a regression. We are reverting the Quincy backport so we can release 17.2.4: #48104
See https://tracker.ceph.com/issues/57546 for more details.
Member
|
jenkins retest this please |
Member
|
Let's close this, as there doesn't seem to be a fix to help with the teuthology regression, and Pacific is going EOL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/56734
backport of #44499
parent tracker: https://tracker.ceph.com/issues/53806
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh