Skip to content

rgw: ContinuousLeaseCR uses LOCK_FLAG_MUST_RENEW to detect timeouts and racing lockers#47809

Closed
cbodley wants to merge 4 commits intoceph:mainfrom
cbodley:wip-rgw-lock-cr
Closed

rgw: ContinuousLeaseCR uses LOCK_FLAG_MUST_RENEW to detect timeouts and racing lockers#47809
cbodley wants to merge 4 commits intoceph:mainfrom
cbodley:wip-rgw-lock-cr

Conversation

@cbodley
Copy link
Contributor

@cbodley cbodley commented Aug 25, 2022 •
edited
Loading

allow SimpleRadosLock/UnlockCRs to take rados::cls::lock::Lock directly, so that callers like ContinuousLeaseCR can override set_may_renew()/set_must_renew(). ContinuousLeaseCR uses set_must_renew() to raise EBUSY errors if a renewal request is processed after expiration

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@github-actions github-actions bot added the rgw label Aug 25, 2022
@cbodley cbodley mentioned this pull request Aug 25, 2022
Merged
14 tasks
@yuvalif
Copy link
Contributor

yuvalif commented Aug 25, 2022

can you please provide an example of usage for the new ctor (rgw_sync.cc or rgw_data_sync.cc)?

@cbodley
Copy link
Contributor Author

cbodley commented Aug 25, 2022

added a commit that starts on RGWContinuousLeaseCR integration. it's not complete but should be useful as an example

@yuvalif yuvalif self-requested a review August 27, 2022 10:59
@github-actions
Copy link

github-actions bot commented Aug 28, 2022

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@cbodley
rgw: RGWSimpleRadosLock/UnlockCR can take cls Lock directly
c067993 
this allows the caller to override the default set_may_renew(true)

Signed-off-by: Casey Bodley <cbodley@redhat.com>
@cbodley cbodley changed the title rgw: RGWSimpleRadosLockCR can take cls Lock directly rgw: ContinuousLeaseCR uses LOCK_FLAG_MUST_RENEW to detect timeouts and racing lockers Sep 15, 2022
@cbodley cbodley marked this pull request as ready for review September 15, 2022 16:33
@cbodley cbodley requested a review from ofriedma September 15, 2022 16:37
@cbodley
rgw: RGWContinuousLeaseCR manages its own cls Lock
f57e6c3 
Signed-off-by: Casey Bodley <cbodley@redhat.com>
@cbodley
rgw: ContinuousLeaseCR uses Clock typedef
7f8a9b1 
Signed-off-by: Casey Bodley <cbodley@redhat.com>
@cbodley
rgw: use LOCK_FLAG_MUST_RENEW in ContinuousLeaseCR
785cfdc 
turns late lock renewals into EBUSY errors, and moves the warning
message into that error case

Signed-off-by: Casey Bodley <cbodley@redhat.com>
@github-actions
Copy link

github-actions bot commented Nov 30, 2022

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@yuvalif
Copy link
Contributor

yuvalif commented Dec 8, 2022

@cbodley should this PR go into PR #48898 ?

@cbodley
Copy link
Contributor Author

cbodley commented Dec 8, 2022

i was planning to revisit this one after multisite stabilization and sync fairness

@github-actions
Copy link

github-actions bot commented May 26, 2023

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label May 26, 2023
@github-actions
Copy link

github-actions bot commented Jun 25, 2023

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!

@github-actions github-actions bot closed this Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuvalif yuvalif yuvalif approved these changes

@ofriedma ofriedma Awaiting requested review from ofriedma

Assignees

No one assigned

Labels

needs-rebase rgw stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cbodley @yuvalif