Skip to content

os/bluestore: assert on improper release in AvlAllocator#47730

Merged
ifed01 merged 3 commits intoceph:mainfrom
ifed01:wip-ifed-alloc-logging
Nov 1, 2023
Merged

os/bluestore: assert on improper release in AvlAllocator#47730
ifed01 merged 3 commits intoceph:mainfrom
ifed01:wip-ifed-alloc-logging

Conversation

@ifed01
Copy link
Copy Markdown
Contributor

@ifed01 ifed01 commented Aug 22, 2022

Let's assert on unexpected unit release before we damage internal data structures.
Plus uniforms some logging output for avl/hybrid allocator with bitmap one to enable replay
tool usage.

Signed-off-by: Igor Fedotov igor.fedotov@croit.io

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@ifed01 ifed01 requested a review from a team as a code owner August 22, 2022 14:32
@ifed01 ifed01 requested a review from aclamk August 22, 2022 14:33
@github-actions github-actions bot added the core label Aug 22, 2022
@ifed01 ifed01 changed the title os/bluestore: assert on improper releases in AvlAllocator os/bluestore: assert on improper release in AvlAllocator Aug 22, 2022
@ifed01
Copy link
Copy Markdown
Contributor Author

ifed01 commented Dec 9, 2022

jenkins test make check

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 15, 2022

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@ifed01
os/bluestore: assert on improper releases in AvlAllocator
3c92213 
Let's assert on unexpected unit release before we damage internal data structures.
Plus uniforms some logging output for avl/hybrid allocator with bitmap one to enable replay
tool usage.

Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
@ifed01
os/bluestore: log values in hex in AvlAllocator
5b6be45 
Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
@ifed01
os/bluestore: do not call allocator's release on empty set
36961d6 
Signed-off-by: Igor Fedotov <ifedotov@croit.io>
@ifed01 ifed01 force-pushed the wip-ifed-alloc-logging branch from 8ec1769 to 36961d6 Compare December 19, 2022 08:39
@ifed01
Copy link
Copy Markdown
Contributor Author

ifed01 commented Dec 19, 2022

jenkins test make check

1 similar comment
@ifed01
Copy link
Copy Markdown
Contributor Author

ifed01 commented Dec 19, 2022

jenkins test make check

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 23, 2023

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label May 23, 2023
@ifed01
Copy link
Copy Markdown
Contributor Author

ifed01 commented May 23, 2023

jenkins test make check

@github-actions github-actions bot removed the stale label May 23, 2023
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 22, 2023

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Jul 22, 2023
@ifed01
Copy link
Copy Markdown
Contributor Author

ifed01 commented Jul 22, 2023

jenkins test make check

@ifed01
Copy link
Copy Markdown
Contributor Author

ifed01 commented Jul 22, 2023

@aclamk - ping!

@github-actions github-actions bot removed the stale label Jul 22, 2023
@rzarzynski
Copy link
Copy Markdown
Contributor

rzarzynski commented Sep 5, 2023

@pereman2: how about taking a look?

@NitzanMordhai
Copy link
Copy Markdown
Contributor

NitzanMordhai commented Oct 31, 2023

Rados review : https://tracker.ceph.com/projects/rados/wiki/MAIN#httpspulpitocephcomyuriw-2023-10-30_153436-rados-wip-yuri10-testing-2023-10-27-0804-distro-default-smithi

@yuriw
Copy link
Copy Markdown
Contributor

yuriw commented Oct 31, 2023

@ifed01 this was tested and ready for merge
pls merge when ready
ref: https://trello.com/c/IdHRIj6u

@yuriw
Copy link
Copy Markdown
Contributor

yuriw commented Oct 31, 2023

jenkins test windows

@ifed01 ifed01 merged commit 542d7fb into ceph:main Nov 1, 2023
@ifed01 ifed01 deleted the wip-ifed-alloc-logging branch November 1, 2023 09:38
@jbaergen-do jbaergen-do mentioned this pull request Mar 27, 2025
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pereman2 pereman2 pereman2 approved these changes

@aclamk aclamk Awaiting requested review from aclamk

Assignees

No one assigned

Labels

bluestore core needs-qa ready-to-merge TESTED

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ifed01 @rzarzynski @NitzanMordhai @yuriw @pereman2 @ljflores