Skip to content

install-deps: bring argv parsing for --crimson and others#47697

Closed
rzarzynski wants to merge 1 commit intoceph:mainfrom
rzarzynski:wip-build-argv4install-deps
Closed

install-deps: bring argv parsing for --crimson and others#47697
rzarzynski wants to merge 1 commit intoceph:mainfrom
rzarzynski:wip-build-argv4install-deps

Conversation

@rzarzynski
Copy link
Contributor

The --crimson argv switch is respected by many our development scripts like vstart.sh and stop.sh. However, install-deps.sh still requires setting the WITH_SEASTAR environment variable which departs from this convention.

This commit brings argv support for --crimson, --jaeger and --zbd while keeping the old, env-based way intact.

Signed-off-by: Radoslaw Zarzynski rzarzyns@redhat.com

CC: @JoshSalomon

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

The `--crimson` argv switch is respected by many our development
scripts like `vstart.sh` and `stop.sh`. However, `install-deps.sh`
still requires setting the `WITH_SEASTAR` environment variable
which departs from this convention.

This commit brings argv support for `--crimson`, `--jaeger` and
`--zbd` while keeping the old, env-based way intact.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
@ljflores
Copy link
Member

jenkins test api

@github-actions
Copy link

github-actions bot commented Mar 6, 2023

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label May 22, 2023
@github-actions
Copy link

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!

@github-actions github-actions bot closed this Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants