Skip to content

rgw/multisite: add cls versioning for tracking data sync per shard object#47682

Closed
smanjara wants to merge 1 commit intoceph:mainfrom
smanjara:rgw-cls-version-sync-shard
Closed

rgw/multisite: add cls versioning for tracking data sync per shard object#47682
smanjara wants to merge 1 commit intoceph:mainfrom
smanjara:rgw-cls-version-sync-shard

Conversation

@smanjara
Copy link
Contributor

@smanjara smanjara commented Aug 18, 2022

Replaces #47614

Also stores the RGWObjVersionTracker's in a vector.

Signed-off-by: Shilpa Jagannath smanjara@redhat.com

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@github-actions github-actions bot added the rgw label Aug 18, 2022
@smanjara smanjara mentioned this pull request Aug 18, 2022
Closed
14 tasks
cbodley
cbodley reviewed Aug 18, 2022
View reviewed changes
@smanjara smanjara force-pushed the rgw-cls-version-sync-shard branch from b673fc4 to d07ba6a Compare August 18, 2022 20:32
@cbodley
Copy link
Contributor

cbodley commented Aug 19, 2022

from make check:

/home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_data_sync.cc
/home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_data_sync.cc:134:37: error: reference cannot be bound to dereferenced null pointer in well-defined C++ code; pointer may be assumed to always convert to true [-Werror,-Wundefined-bool-conversion]
               &markers[shard_id], &objvs[shard_id]),
                                    ^~~~~~~~~~~~~~~

@cbodley cbodley removed the needs-qa label Aug 19, 2022
@smanjara
Copy link
Contributor Author

smanjara commented Aug 22, 2022

from make check:

/home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_data_sync.cc
/home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_data_sync.cc:134:37: error: reference cannot be bound to dereferenced null pointer in well-defined C++ code; pointer may be assumed to always convert to true [-Werror,-Wundefined-bool-conversion]
               &markers[shard_id], &objvs[shard_id]),
                                    ^~~~~~~~~~~~~~~

oh, I didn't see this error when I built locally.

@smanjara smanjara force-pushed the rgw-cls-version-sync-shard branch 2 times, most recently from 6f062f5 to 8ce5341 Compare August 26, 2022 14:50
@smanjara
Copy link
Contributor Author

smanjara commented Aug 26, 2022

from make check:

/home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_data_sync.cc
/home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_data_sync.cc:134:37: error: reference cannot be bound to dereferenced null pointer in well-defined C++ code; pointer may be assumed to always convert to true [-Werror,-Wundefined-bool-conversion]
               &markers[shard_id], &objvs[shard_id]),
                                    ^~~~~~~~~~~~~~~

oh, I didn't see this error when I built locally.

thanks to @adamemerson! Pushed an update

@smanjara smanjara force-pushed the rgw-cls-version-sync-shard branch from 8ce5341 to 62a7af3 Compare August 26, 2022 15:02
@smanjara
Copy link
Contributor Author

smanjara commented Aug 26, 2022

jenkins make check

@smanjara smanjara force-pushed the rgw-cls-version-sync-shard branch from 62a7af3 to 3bd257d Compare September 9, 2022 15:16
@smanjara
Copy link
Contributor Author

smanjara commented Sep 9, 2022

unrelated make check failure. @cbodley should I run tests on this pr separately or can we batch it up with other pr's?

@cbodley
Copy link
Contributor

cbodley commented Sep 9, 2022

unrelated make check failure. @cbodley should I run tests on this pr separately or can we batch it up with other pr's?

batching is fine 👍

@smanjara
Copy link
Contributor Author

smanjara commented Oct 5, 2022

some multisite test failures
http://pulpito.front.sepia.ceph.com/smanjara-2022-09-22_02:46:16-rgw:multisite-rgw-cls-version-sync-shard-distro-default-smithi/7040862/

@cbodley
Copy link
Contributor

cbodley commented Oct 5, 2022

yeah, there are several segfaults in there. can you try rebasing to make sure we have all the latest fixes?

rgw/multisite: add cls versioning for tracking data sync per shard ob…
565c3ca 
…ject and store it in a vector

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>
@smanjara smanjara force-pushed the rgw-cls-version-sync-shard branch from 3bd257d to 565c3ca Compare October 5, 2022 19:33
@cbodley cbodley mentioned this pull request Oct 6, 2022
Closed
18 tasks
@smanjara
Copy link
Contributor Author

smanjara commented Oct 6, 2022

yeah, there are several segfaults in there. can you try rebasing to make sure we have all the latest fixes?

ran the suite again after rebasing.

http://qa-proxy.ceph.com/teuthology/smanjara-2022-10-06_13:48:47-rgw:multisite-rgw-cls-version-sync-shard-distro-default-smithi/7057068/teuthology.log

we seem to have sync failures

@soumyakoduri soumyakoduri mentioned this pull request Oct 7, 2022
Closed
14 tasks
@cbodley
Copy link
Contributor

cbodley commented Nov 22, 2022

this will merge through #48898

@cbodley cbodley closed this Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbodley cbodley cbodley approved these changes

@adamemerson adamemerson Awaiting requested review from adamemerson

Assignees

No one assigned

Labels

needs-qa rgw

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@smanjara @cbodley