Skip to content

qa/cephadm: specify using container host distros for workunits#47674

Merged
adk3798 merged 1 commit intoceph:mainfrom
adk3798:distro-workunits
Aug 25, 2022
Merged

qa/cephadm: specify using container host distros for workunits#47674
adk3798 merged 1 commit intoceph:mainfrom
adk3798:distro-workunits

Conversation

@adk3798
Copy link
Contributor

@adk3798 adk3798 commented Aug 18, 2022

Right now, the OS Type and OS Version for these workunits
tests is left blank on pulpito and they appear to be trying to
run ubuntu jammy currently which is causing failures. We should
specify what distros the tests should run on then very explicitly
tell it to start trying new distros when we can get the tests to
pass.

Signed-off-by: Adam King adking@redhat.com

Not entirely sure the patch as I have it is correct. Will need to just try it and make sure cephadm/workunits tests
are assigned a proper distro and and also the test-iscsi-pids-limit test in particular is still only tested on centos

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

Right now, the OS Type and OS Version for these workunits
tests is left blank on pulpito and they appear to be trying to
run ubuntu jammy currently which is causing failures. We should
specify what distros the tests should run on then very explicitly
tell it to start trying new distros when we can get the tests to
pass.

Signed-off-by: Adam King <adking@redhat.com>
@adk3798 adk3798 requested a review from a team as a code owner August 18, 2022 13:00
@adk3798
Copy link
Contributor Author

adk3798 commented Aug 18, 2022

example of what I mean by the os type/version being left blank from https://pulpito.ceph.com/adking-2022-08-18_01:28:05-orch:cephadm-wip-adk-testing-2022-08-17-1914-distro-default-smithi/

image

you can see the last test was explicitly given rhel 8.6, but the other ones, which are all workunits, have blank fields. They appear to be trying to run on ubuntu jammy given

2022-08-18T08:17:11.283 DEBUG:teuthology.orchestra.run.smithi153:> cat /etc/os-release
2022-08-18T08:17:11.287 INFO:teuthology.orchestra.run.smithi153.stdout:PRETTY_NAME="Ubuntu 22.04 LTS"
2022-08-18T08:17:11.287 INFO:teuthology.orchestra.run.smithi153.stdout:NAME="Ubuntu"
2022-08-18T08:17:11.288 INFO:teuthology.orchestra.run.smithi153.stdout:VERSION_ID="22.04"
2022-08-18T08:17:11.288 INFO:teuthology.orchestra.run.smithi153.stdout:VERSION="22.04 LTS (Jammy Jellyfish)"
2022-08-18T08:17:11.288 INFO:teuthology.orchestra.run.smithi153.stdout:VERSION_CODENAME=jammy
2022-08-18T08:17:11.288 INFO:teuthology.orchestra.run.smithi153.stdout:ID=ubuntu
2022-08-18T08:17:11.289 INFO:teuthology.orchestra.run.smithi153.stdout:ID_LIKE=debian
2022-08-18T08:17:11.289 INFO:teuthology.orchestra.run.smithi153.stdout:HOME_URL="https://www.ubuntu.com/"
2022-08-18T08:17:11.289 INFO:teuthology.orchestra.run.smithi153.stdout:SUPPORT_URL="https://help.ubuntu.com/"
2022-08-18T08:17:11.289 INFO:teuthology.orchestra.run.smithi153.stdout:BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
2022-08-18T08:17:11.289 INFO:teuthology.orchestra.run.smithi153.stdout:PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
2022-08-18T08:17:11.290 INFO:teuthology.orchestra.run.smithi153.stdout:UBUNTU_CODENAME=jammy

@adk3798
Copy link
Contributor Author

adk3798 commented Aug 18, 2022

jenkins test api

@adk3798
Copy link
Contributor Author

adk3798 commented Aug 18, 2022

jenkins test api

2 similar comments
@ljflores
Copy link
Member

jenkins test api

@adk3798
Copy link
Contributor Author

adk3798 commented Aug 23, 2022

jenkins test api

@adk3798
Copy link
Contributor Author

adk3798 commented Aug 25, 2022

without this change https://pulpito.ceph.com/adking-2022-08-23_20:19:52-orch:cephadm-wip-adk-main-testing-2022-08-23-1319-distro-default-smithi/

and with it https://pulpito.ceph.com/adking-2022-08-24_13:29:10-orch:cephadm-wip-adk-main-testing-2022-08-24-0725-distro-default-smithi/

lots of dead jobs due to an unrelated thing causing rhel jobs to fail, but overall the cephadm/workunits tests are much better with this change. Additionally, that has revealed we seem to have 2 other failures in the suite now, not caused by this I think

https://tracker.ceph.com/issues/57287
https://tracker.ceph.com/issues/57290

@adk3798 adk3798 merged commit ee70013 into ceph:main Aug 25, 2022
@ljflores
Copy link
Member

@adk3798 will this PR also help with https://tracker.ceph.com/issues/57303?

@adk3798
Copy link
Contributor Author

adk3798 commented Aug 26, 2022

@adk3798 will this PR also help with https://tracker.ceph.com/issues/57303?

I would think so. I see what looks like the same failure in https://pulpito.ceph.com/adking-2022-08-23_20:19:52-orch:cephadm-wip-adk-main-testing-2022-08-23-1319-distro-default-smithi/6988142 which was my run without this change and don't see anything similar in runs with this change. I'm going to mark the tracker as resolved by this PR, but we can open again if it pops up in builds that include this patch

@ljflores
Copy link
Member

Thx! I'll reopen it if I see it again. It was happening very consistently in the rados suite, so we'll know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants