pybind/rados: notify callback reconnect#47668
Conversation
when testing with socket injection, reconnect won't call error callback for each reconnect, the callback will be called. changing the callback count of notify by the data and increass only when the data is changed, if the data is the same, we probably reconnecting due to socket injection. Fixes: https://tracker.ceph.com/issues/45721 Signed-off-by: Nitzan Mordechai <nmordec@redhat.com>
c72279f to
583b903
Compare
|
@NitzanMordhai to test, we could try running a test like http://pulpito.front.sepia.ceph.com/yuriw-2022-08-22_16:21:19-rados-wip-yuri8-testing-2022-08-22-0646-distro-default-smithi/6985089/ 50-100 times to verify instead of running against the whole rados suite. |
@ljflores good idea, will do it |
|
@ljflores |
@NitzanMordhai do we need any more testing for this PR? |
@neha-ojha i think that my run is enough to prove it. |
when testing with socket injection, reconnect won't call error callback
for each reconnect, the callback will be called.
changing the callback count of notify by the data and increass only
when the data is changed, if the data is the same, we probably reconnecting
due to socket injection.
Fixes: https://tracker.ceph.com/issues/45721
Signed-off-by: Nitzan Mordechai nmordec@redhat.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows