Skip to content

pacific: ceph-volume: system.get_mounts() refactor#47535

Merged
adk3798 merged 1 commit intoceph:pacificfrom
guits:wip-57088-pacific
Sep 6, 2022
Merged

pacific: ceph-volume: system.get_mounts() refactor#47535
adk3798 merged 1 commit intoceph:pacificfrom
guits:wip-57088-pacific

Conversation

@guits
Copy link
Contributor

@guits guits commented Aug 10, 2022

backport tracker: https://tracker.ceph.com/issues/57088


backport of #47514
parent tracker: https://tracker.ceph.com/issues/57070

this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh

When a network mount is present in `/proc/mounts` but for any reason
the corresponding server is down, this function hangs forever.
In a cluster deployed with cephadm, the consequence is that
it triggers `ceph-volume inventory` commands that hang and stay in D
state.

The idea here is to use a thread with a timeout to abort the call if the
timeout is reached.
`get_mounts()` is now a method of a class so we can exclude a path
altogether during the whole `inventory` execution (otherwise,
ceph-volume would try to access it as many devices there is on the
host which could slow down the inventory execution)

Fixes: https://tracker.ceph.com/issues/57070

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit 89cad1f)
@guits guits requested a review from a team as a code owner August 10, 2022 12:49
@guits guits added this to the pacific milestone Aug 10, 2022
@guits
Copy link
Contributor Author

guits commented Aug 10, 2022

jenkins test ceph-volume tox

@adk3798
Copy link
Contributor

adk3798 commented Aug 18, 2022

https://pulpito.ceph.com/adking-2022-08-17_23:17:58-orch:cephadm-wip-adk2-testing-2022-08-17-1543-pacific-distro-default-smithi/

1 failure from https://tracker.ceph.com/issues/55347
dashboard e2e test appears to have failed taking a host out of maintenance mode. Looks unrelated to PRs in the run.

@adk3798 adk3798 merged commit 3840f8b into ceph:pacific Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants