osd: remove invalid put on message#47379
Merged
Conversation
NitzanMordhai
commented
Aug 1, 2022
tchaikov
approved these changes
Aug 1, 2022
neha-ojha
approved these changes
Aug 1, 2022
Member
|
jenkins test make check |
message converted to use smart pointer, the put is extra step that causing the double put and valgrind error the regression was introduced by d4a71c3 Fixes: https://tracker.ceph.com/issues/52124 Signed-off-by: Nitzan Mordechai <nmordec@redhat.com>
b0545c1 to
c449638
Compare
Contributor
Author
|
jenkins test make check |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
message converted to use smart pointer, the put is extra step that
causing the double put and valgrind error
Fixes: https://tracker.ceph.com/issues/52124
Signed-off-by: Nitzan Mordechai nmordec@redhat.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows