Skip to content

librados: rados_ioctx_destroy check for initialized ioctx#47165

Merged
yuriw merged 1 commit intoceph:mainfrom
NitzanMordhai:wip-nitzan-librados-ioctx-destroy-Segmentation-fault
Aug 3, 2022
Merged

librados: rados_ioctx_destroy check for initialized ioctx#47165
yuriw merged 1 commit intoceph:mainfrom
NitzanMordhai:wip-nitzan-librados-ioctx-destroy-Segmentation-fault

Conversation

@NitzanMordhai
Copy link
Contributor

@NitzanMordhai NitzanMordhai commented Jul 19, 2022

If rados_ioctx_destroy called with un-initilized ioctx we will hit segmented fault
checking ioctx before calling put will prevent that.

Fixes: https://tracker.ceph.com/issues/55001
Signed-off-by: Nitzan Mordechai nmordec@redhat.com

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

If rados_ioctx_destroy called with un-initilized ioctx we will hit segmented fault
checking ioctx before calling put will prevent that.

Fixes: https://tracker.ceph.com/issues/55001
Signed-off-by: Nitzan Mordechai <nmordec@redhat.com>
@NitzanMordhai NitzanMordhai requested a review from a team as a code owner July 19, 2022 10:23
@github-actions github-actions bot added the core label Jul 19, 2022
Copy link
Member

@ljflores ljflores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@NitzanMordhai
Copy link
Contributor Author

jenkins test windows

@kamoltat
Copy link
Member

kamoltat commented Aug 3, 2022

@yuriweinstein Rados approved

Related Failures:

/a/yuriw-2022-07-22_03:30:40-rados-wip-yuri3-testing-2022-07-21-1604-distro-default-smithi/6943775

due to ceph/ceph: Pull Request 46036

Unrelated Failures already with Tracker:
Bug #52124: Invalid read of size 8 in handle_recovery_delete() - RADOS - Ceph
Bug #52321: qa/tasks/rook times out: 'check osd count' reached maximum tries (90) after waiting for 900 seconds - Orchestrator - Ceph
Bug #56652: cephadm/test_repos.sh: rllib.error.HTTPError: HTTP Error 504: Gateway Timeout - Orchestrator - Ceph
Bug #55001: rados/test.sh: Early exit right after LibRados global tests complete - RADOS - Ceph
Bug #53768: timed out waiting for admin_socket to appear after osd.2 restart in thrasher/defaults workload/small-objects - crimson - Ceph
Bug #48819: fsck error: found stray (per-pg) omap data on omap_head - bluestore - Ceph
Bug #55853: test_cls_rgw.sh: failures in 'cls_rgw.index_list' and 'cls_rgw.index_list_delimited` - rgw - Ceph
Bug #52652: ERROR: test_module_commands (tasks.mgr.test_module_selftest.TestModuleSelftest) - mgr - Ceph
Bug #55142: [ERR] : Unhandled exception from module 'devicehealth' while running on mgr.gibba002.nzpbzu: disk I/O error - cephsqlite - Ceph
Bug #44587: failed to write to cgroup.procs: - Orchestrator - Ceph
Bug #56716: RuntimeError: ceph version 16.2.10-515.g3bc1d6b2 was not installed, found 16.2.10-513.gc2f1041a.el8. - teuthology - Ceph

Unrelated Failures without Tracker:
Bug #57015: bluestore::NCB::__restore_allocator::No Valid allocation info on disk (empty file) - RADOS - Ceph
Infrastructure: Bug #56717: The package cache file is corrupted - teuthology - Ceph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants