Skip to content

test/cls_lock: expired lock before unlock and start check#47148

Merged
cbodley merged 1 commit intoceph:mainfrom
NitzanMordhai:wip-nitzan-test-cls-lock-expiered-locks-start
Oct 2, 2023
Merged

test/cls_lock: expired lock before unlock and start check#47148
cbodley merged 1 commit intoceph:mainfrom
NitzanMordhai:wip-nitzan-test-cls-lock-expiered-locks-start

Conversation

@NitzanMordhai
Copy link
Contributor

@NitzanMordhai NitzanMordhai commented Jul 18, 2022 •
edited
Loading

If the lock expired, the stat check shouldn't return -ENOENT, we need to check before if the lock
expired and check stat accordingly

Fixes: https://tracker.ceph.com/issues/56575
Signed-off-by: Nitzan Mordechai nmordec@redhat.com

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@NitzanMordhai NitzanMordhai requested a review from a team as a code owner July 18, 2022 10:17
@github-actions github-actions bot added the tests label Jul 18, 2022
ljflores
ljflores reviewed Jul 18, 2022
View reviewed changes
@NitzanMordhai NitzanMordhai force-pushed the wip-nitzan-test-cls-lock-expiered-locks-start branch from 811efca to 95e27e8 Compare July 19, 2022 04:49
@NitzanMordhai NitzanMordhai requested a review from ljflores July 19, 2022 04:50
@idryomov idryomov changed the title cls_lock: expired lock before unlock and start check test/cls_lock: expired lock before unlock and start check Jul 19, 2022
idryomov
idryomov requested changes Jul 19, 2022
View reviewed changes
@idryomov idryomov requested a review from ivancich July 19, 2022 09:31
@badone
Copy link
Contributor

badone commented Aug 30, 2022

I'll take a look into this and try to work out how we got here. It seems these tests have become very problematic over time and perhaps a comprehensive review is in order?

@NitzanMordhai NitzanMordhai force-pushed the wip-nitzan-test-cls-lock-expiered-locks-start branch from 95e27e8 to daced6a Compare October 27, 2022 09:02
@NitzanMordhai NitzanMordhai force-pushed the wip-nitzan-test-cls-lock-expiered-locks-start branch from daced6a to ef08832 Compare October 27, 2022 09:05
@tchaikov
Copy link
Contributor

tchaikov commented Oct 27, 2022

jenkins test make check

idryomov
idryomov reviewed Nov 1, 2022
View reviewed changes
Copy link
Contributor

@idryomov idryomov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR should just remove lock_expired function, completely reverting the changes made in #45762. Then, on top of the revert, apply two set_duration fixups and that is it.

@NitzanMordhai NitzanMordhai force-pushed the wip-nitzan-test-cls-lock-expiered-locks-start branch from ef08832 to a0e6c79 Compare December 25, 2022 15:30
idryomov
idryomov reviewed Jan 3, 2023
View reviewed changes
@NitzanMordhai NitzanMordhai force-pushed the wip-nitzan-test-cls-lock-expiered-locks-start branch from a0e6c79 to c276843 Compare January 4, 2023 15:00
@NitzanMordhai NitzanMordhai requested a review from idryomov January 4, 2023 15:00
@badone
Copy link
Contributor

badone commented Jan 4, 2023

jenkins test windows

@idryomov
Copy link
Contributor

idryomov commented Jan 4, 2023 •
edited
Loading

jenkins test windows

It's going to fail but there is work in flight to get that fixed, hopefully tomorrow!

@idryomov
Copy link
Contributor

idryomov commented Jan 9, 2023

jenkins test windows

@github-actions
Copy link

github-actions bot commented Apr 27, 2023

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Apr 27, 2023
@idryomov idryomov added needs-qa and removed stale labels Apr 28, 2023
@github-actions
Copy link

github-actions bot commented Jun 27, 2023

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Jun 27, 2023
@badone badone removed the stale label Jun 27, 2023
@idryomov
Copy link
Contributor

idryomov commented Jun 28, 2023

@yuriw A gentle needs-qa poke ;)

@NitzanMordhai
cls_lock: expired lock before unlock and start check
d3457c6 
If the lock expired, the stat check shouldn't return -ENOENT,
We will change the lock duration to prevent lock expired before the
stat check.

Fixes: https://tracker.ceph.com/issues/56575
Signed-off-by: Nitzan Mordechai <nmordec@redhat.com>
@NitzanMordhai NitzanMordhai force-pushed the wip-nitzan-test-cls-lock-expiered-locks-start branch from c276843 to d3457c6 Compare August 1, 2023 07:57
@NitzanMordhai NitzanMordhai requested a review from a team as a code owner August 1, 2023 07:57
@cbodley
Copy link
Contributor

cbodley commented Aug 1, 2023

215/285 Test #224: unittest_rgw_amqp .........................***Failed 35.29 sec

saw an unrelated 'make check' failure and opened https://tracker.ceph.com/issues/62264 to track it

@github-actions
Copy link

github-actions bot commented Sep 30, 2023

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Sep 30, 2023
@idryomov
Copy link
Contributor

idryomov commented Oct 2, 2023

jenkins test make check

@idryomov idryomov removed the stale label Oct 2, 2023
@cbodley
Copy link
Contributor

cbodley commented Oct 2, 2023 •
edited
Loading

builds pending in https://shaman.ceph.com/builds/ceph/pr-47148/

i just want to see the updated ceph_test_cls_lock pass, so i'm planning to schedule a single rados/basic/tasks/rados_cls_all.yaml job to verify. would that satisfy you too @idryomov, or would you like to run part of the rbd suite?

@idryomov
Copy link
Contributor

idryomov commented Oct 2, 2023 •
edited
Loading

@cbodley Nothing in RBD touches lock duration, so whatever you do is fine with me.

@cbodley
Copy link
Contributor

cbodley commented Oct 2, 2023

scheduled with: teuthology-suite -m smithi -s rados/basic -c pr-47148 --filter cls --limit 1 -p 75

results: http://qa-proxy.ceph.com/teuthology/cbodley-2023-10-02_19:06:34-rados:basic-pr-47148-distro-default-smithi/7408609/teuthology.log

2023-10-02T19:28:53.330 INFO:tasks.workunit.client.0.smithi114.stdout:[ RUN      ] ClsLock.TestExclusiveEphemeralBasic
2023-10-02T19:28:59.403 INFO:tasks.workunit.client.0.smithi114.stdout:[       OK ] ClsLock.TestExclusiveEphemeralBasic (6073 ms)
2023-10-02T19:28:59.404 INFO:tasks.workunit.client.0.smithi114.stdout:[ RUN      ] ClsLock.TestExclusiveEphemeralStealEphemeral
2023-10-02T19:29:07.213 INFO:tasks.workunit.client.0.smithi114.stdout:[       OK ] ClsLock.TestExclusiveEphemeralStealEphemeral (7810 ms)
2023-10-02T19:29:07.214 INFO:tasks.workunit.client.0.smithi114.stdout:[ RUN      ] ClsLock.TestExclusiveEphemeralStealExclusive
2023-10-02T19:29:14.283 INFO:tasks.workunit.client.0.smithi114.stdout:[       OK ] ClsLock.TestExclusiveEphemeralStealExclusive (7069 ms)
2023-10-02T19:29:14.283 INFO:tasks.workunit.client.0.smithi114.stdout:[----------] 11 tests from ClsLock (67949 ms total)
2023-10-02T19:29:14.283 INFO:tasks.workunit.client.0.smithi114.stdout:
2023-10-02T19:29:14.283 INFO:tasks.workunit.client.0.smithi114.stdout:[----------] Global test environment tear-down
2023-10-02T19:29:14.283 INFO:tasks.workunit.client.0.smithi114.stdout:[==========] 11 tests from 1 test suite ran. (67949 ms total)
2023-10-02T19:29:14.283 INFO:tasks.workunit.client.0.smithi114.stdout:[  PASSED  ] 11 tests.

👍

@cbodley cbodley merged commit cc984be into ceph:main Oct 2, 2023
This was referenced Aug 17, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@idryomov idryomov idryomov approved these changes

@cbodley cbodley cbodley approved these changes

@ljflores ljflores Awaiting requested review from ljflores

@ivancich ivancich Awaiting requested review from ivancich

Assignees

No one assigned

Labels

needs-qa tests wip-cbodley-testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@NitzanMordhai @badone @tchaikov @idryomov @cbodley @ljflores