client: do not uninline data for read#47090
Merged
Conversation
We don't even ask for and to be sure that we have granted the Fw caps when reading, we shouldn't write contents to Rados. The bug was introduced by commit a0cb524 (client: Read inline data path) Fixes: https://tracker.ceph.com/issues/56553 Signed-off-by: Xiubo Li <xiubli@redhat.com>
This was referenced Jul 14, 2022
ajarr
approved these changes
Jul 14, 2022
mchangir
approved these changes
Jul 18, 2022
Contributor
mchangir
left a comment
There was a problem hiding this comment.
I wish the initial committer had elaborated on the reasons about why the read path was also chosen for uninlining.
Member
Author
Added the author of that commit to help review this. |
Member
Author
|
@dragonylffly Could you help explain it ? Did we miss something important here ? |
Contributor
|
jenkins test windows |
vshankar
approved these changes
Aug 25, 2022
kotreshhr
approved these changes
Aug 25, 2022
Contributor
This was referenced Sep 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't even ask for and to be sure that we have granted the Fw
caps when reading, we shouldn't write contents to Rados.
The bug was introduced by commit a0cb524
(client: Read inline data path)
Fixes: https://tracker.ceph.com/issues/56553
Signed-off-by: Xiubo Li xiubli@redhat.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows