octopus: Revert "rocksdb: do not use non-zero recycle_log_file_num setting"#47053
Merged
ljflores merged 1 commit intoceph:octopusfrom Jul 12, 2022
Merged
octopus: Revert "rocksdb: do not use non-zero recycle_log_file_num setting"#47053ljflores merged 1 commit intoceph:octopusfrom
ljflores merged 1 commit intoceph:octopusfrom
Conversation
This reverts commit 6e225bf. It causes a consistently-reproducible BlueFS bug. See the tracker for details. Fixes: https://tracker.ceph.com/issues/55636 Signed-off-by: Laura Flores <lflores@redhat.com>
Member
Author
|
@ifed01 I have created this PR to fix https://tracker.ceph.com/issues/55636 since Octopus is going into the final stages of the point release. If you see this before the point release is finalized, let me know if you have a fix you want to try, and I can close this revert. |
Contributor
|
I believe that there is an actual bug in BlueFS. But as intermediary action revert is a best solution. |
ifed01
approved these changes
Jul 12, 2022
Member
Author
|
Merging this, as it has been tested here: https://pulpito.ceph.com/?branch=wip-yuri7-testing-2022-07-08-1007-octopus |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 6e225bf. It
causes a consistently-reproducible BlueFS bug. See the tracker
for details.
Fixes: https://tracker.ceph.com/issues/55636
Signed-off-by: Laura Flores lflores@redhat.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows