qa/cephfs: upgrade method authorize in class Filesystem#47013
Merged
rishabh-d-dave merged 1 commit intoceph:mainfrom Jul 20, 2022
Merged
qa/cephfs: upgrade method authorize in class Filesystem#47013rishabh-d-dave merged 1 commit intoceph:mainfrom
rishabh-d-dave merged 1 commit intoceph:mainfrom
Conversation
4 tasks
Method authorize currently accepts caps as a list that should be as follows - (path1, perm2, path2, perm2) Modify this method to also accepts caps arranged in following format - ((path1, perm1), (path2, perm2), (path3, perm3)) The latter format is pairs the path and the permission to be set on path together. This makes the association more apparent and thus it less prone to human error. Signed-off-by: Rishabh Dave <ridave@redhat.com>
75bee48 to
be4e39e
Compare
Contributor
Author
|
jenkins test make check |
Contributor
Author
|
jenkins test make api |
Contributor
Author
|
jenkins test api |
Contributor
Author
|
jenkins test make check |
Contributor
Author
|
I am seeing "Could not get lock /var/lib/dpkg/lock-frontend. It is held by process 1304852 (apt)" occur too frequently on "ceph API tests" and "make check" CI jobs too frequently. |
Contributor
Author
|
jenkins test make check |
1 similar comment
Contributor
Author
|
jenkins test make check |
Contributor
Author
|
jenkins test api |
vshankar
approved these changes
Jul 15, 2022
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PR - PR #41779. Commits on this PR originally were located on PR #41779. These have been moved to a separate PR for ease of review, testing, merging and, more importantly to get these commits merged sooner so that this code can be reused to write other PRs.
Method authorize currently accepts caps as a list that should be as
follows -
(path1, perm2, path2, perm2)
Modify this method to also accepts caps arranged in following format -
((path1, perm1), (path2, perm2), (path3, perm3))
The latter format is pairs the path and the permission to be set on path
together. This makes the association more apparent and thus it less
prone to human error.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows