mgr/cephadm: check for events key before accessing it#46897
Merged
mgr/cephadm: check for events key before accessing it#46897
Conversation
Fixes: https://tracker.ceph.com/issues/55808 Signed-off-by: Redouane Kachach <rkachach@redhat.com>
Contributor
Author
|
jenkins test make check |
Contributor
|
still seeing a lot of failures in the agent/on test_nfs test. |
Contributor
but it's not failing with the issue in the tracker, so I'm still going to merge this. We'll just also need a fix for the other underlying issue |
adk3798
approved these changes
Jul 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix the issue. Current code assumes that
eventskey always exists which is not correct as this key is optional on the Daemon description and it's only populated once the first daemon event occurs. For example, after a mgr fail over this key doesn't exist. I'm also increasing the timeout to 3 min instead of 2 min as nfs daemon sometimes could take more than 2 min to get up&running (after a mgr fail over).Fixes: https://tracker.ceph.com/issues/55808
Signed-off-by: Redouane Kachach rkachach@redhat.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows