Skip to content

osd, mon: add pglog dups length#46561

Merged
yuriw merged 3 commits intoceph:mainfrom
NitzanMordhai:wip-nitzan-add-pglog-dups-length
Jul 21, 2022
Merged

osd, mon: add pglog dups length#46561
yuriw merged 3 commits intoceph:mainfrom
NitzanMordhai:wip-nitzan-add-pglog-dups-length

Conversation

@NitzanMordhai
Copy link
Contributor

@NitzanMordhai NitzanMordhai commented Jun 8, 2022 •
edited
Loading

Add a new column LOG_DUPS, to the pg dump stats and log_dups_size to pg query
that will show the size of dups entries in pg log.

Fixes: https://tracker.ceph.com/issues/55836
Signed-off-by: Nitzan Mordechai nmordech@redhat.com

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@NitzanMordhai NitzanMordhai requested a review from a team as a code owner June 8, 2022 06:14
rzarzynski
rzarzynski reviewed Jun 8, 2022
View reviewed changes
Copy link
Contributor

@rzarzynski rzarzynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM. One question around the backward compatibility.

@NitzanMordhai NitzanMordhai force-pushed the wip-nitzan-add-pglog-dups-length branch from 451cc68 to ede37ed Compare June 8, 2022 07:06
rzarzynski
rzarzynski approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@rzarzynski rzarzynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

rzarzynski
rzarzynski reviewed Jun 9, 2022
View reviewed changes
src/osd/PeeringState.cc
psdout(10) << __func__ << " approx pg log length = "
<< pg_log.get_log().approx_size() << dendl;
psdout(10) << __func__ << " dups pg log length = "
<< pg_log.get_log().dups.size() << dendl;
Copy link
Contributor

@rzarzynski rzarzynski Jun 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about dissecting this log entry into a tiny, dedicated commit? We could easily and safely backport it everywhere.

Copy link
Member

@neha-ojha neha-ojha Jun 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1!

@sseshasa
Copy link
Contributor

sseshasa commented Jun 29, 2022

Teuthology Test Result
https://pulpito.ceph.com/yuriw-2022-06-27_15:15:17-rados-wip-yuri2-testing-2022-06-24-1331-distro-default-smithi/

Related Failure:
@NitzanMordhai The following failed job appears to be related to this PR. Can you please take a look?
JobID: https://pulpito.ceph.com/yuriw-2022-06-27_15:15:17-rados-wip-yuri2-testing-2022-06-24-1331-distro-default-smithi/6900800
Failure Reason: qa/standalone/osd/repro_long_log.sh failed
Test that failed: TEST_trim_max_entries_with_dups at line 172

@NitzanMordhai
mon: Add duplicate log size to pg dump stats and query
0036934 
Add a new column LOG_DUPS, to the pg dump stats and log_dups_size to pg query
that will show the size of dups entries in pg log.

Signed-off-by: Nitzan Mordechai <nmordech@redhat.com>
@NitzanMordhai
standalone/osd: Test log_dups_size output from pg query
2aecf0d 
Add to the current test of log_size the log_dups_size output test

Signed-off-by: Nitzan Mordechai <nmordech@redhat.com>
@NitzanMordhai
osd: Add duplicate log size to pg dump stats and query
7b4acb7 
Add a new column LOG_DUPS, to the pg dump stats and log_dups_size to pg query
that will show the size of dups entries in pg log.

Signed-off-by: Nitzan Mordechai <nmordech@redhat.com>
@NitzanMordhai NitzanMordhai force-pushed the wip-nitzan-add-pglog-dups-length branch from ede37ed to 7b4acb7 Compare June 30, 2022 08:11
@NitzanMordhai
Copy link
Contributor Author

NitzanMordhai commented Jun 30, 2022 •
edited
Loading

Teuthology Test Result https://pulpito.ceph.com/yuriw-2022-06-27_15:15:17-rados-wip-yuri2-testing-2022-06-24-1331-distro-default-smithi/

Related Failure: @NitzanMordhai The following failed job appears to be related to this PR. Can you please take a look? JobID: https://pulpito.ceph.com/yuriw-2022-06-27_15:15:17-rados-wip-yuri2-testing-2022-06-24-1331-distro-default-smithi/6900800 Failure Reason: qa/standalone/osd/repro_long_log.sh failed Test that failed: TEST_trim_max_entries_with_dups at line 172

I see my mistake, and correcting it

@NitzanMordhai
Copy link
Contributor Author

NitzanMordhai commented Jun 30, 2022

jenkins test api

@NitzanMordhai
Copy link
Contributor Author

NitzanMordhai commented Jul 4, 2022

jenkins test windows

@NitzanMordhai
Copy link
Contributor Author

NitzanMordhai commented Jul 17, 2022

https://pulpito.ceph.com/yuriw-2022-07-09_14:48:58-rados-wip-yuri6-testing-2022-07-07-1429-distro-default-smithi/

Failures, unrelated:
6921591 - https://tracker.ceph.com/issues/52321
6921593 - https://tracker.ceph.com/issues/52321
6921594 - https://tracker.ceph.com/issues/55789
6921595 - https://tracker.ceph.com/issues/52321
6921596 - https://tracker.ceph.com/issues/52321
6921597 - https://tracker.ceph.com/issues/55789

Details:
6921591\6921593\6921595\6921596 - qa/tasks/rook times out: 'check osd count' reached maximum tries (90) after waiting for 900 seconds - Ceph - Rook
6921594\6921597 - cls_rgw.index_suggest_complete assert failuer during test

@yuriw yuriw merged commit 48d7818 into ceph:main Jul 21, 2022
@ljflores ljflores mentioned this pull request Aug 23, 2022
Merged
14 tasks
This was referenced Aug 28, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rzarzynski rzarzynski rzarzynski approved these changes

@neha-ojha neha-ojha Awaiting requested review from neha-ojha

Assignees

No one assigned

Labels

core mon needs-qa wip-yuri6-testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@NitzanMordhai @sseshasa @rzarzynski @neha-ojha @yuriw