quincy: osd/scrub: do not start scrubbing if the PG is snap-trimming#46498
Merged
yuriw merged 1 commit intoceph:quincyfrom Jul 20, 2022
Merged
quincy: osd/scrub: do not start scrubbing if the PG is snap-trimming#46498yuriw merged 1 commit intoceph:quincyfrom
yuriw merged 1 commit intoceph:quincyfrom
Conversation
Both 'snap-trim' and 'snaptrim-wait' PG states now prevent scrub from starting. Background: A PG should not be scrubbed and trimmed concurrently. Unlike write operations, snap trimming does not verify that a targeted object is not in the executing scrub's chunk. The trimmer always checked for active scrubs before starting. The scrubber - did not. This PR fixes that omission. Fixes: https://tracker.ceph.com/issues/49525 Signed-off-by: Ronen Friedman <rfriedma@redhat.com> (cherry picked from commit 51816cd)
Contributor
Author
|
I marked it DNM, as I would rather have the 'main' version collect some track record before merging the backport. |
neha-ojha
approved these changes
Jun 22, 2022
Member
|
jenkins test make check |
Contributor
|
Main PR: #46440. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both 'snap-trim' and 'snaptrim-wait' PG states now prevent
scrub from starting.
Background:
A PG should not be scrubbed and trimmed concurrently. Unlike
write operations, snap trimming does not verify that a targeted
object is not in the executing scrub's chunk.
The trimmer always checked for active scrubs before starting. The
scrubber - did not. This PR fixes that omission.
Fixes: https://tracker.ceph.com/issues/49525
Signed-off-by: Ronen Friedman rfriedma@redhat.com
(cherry picked from commit 51816cd)