mgr/dashboard: fix drain e2e failure #46475
Merged
Conversation
Member
Author
|
jenkins test dashboard |
Member
Author
|
jenkins test dashboard cephadm |
epuertat
approved these changes
Jun 1, 2022
Member
epuertat
left a comment
There was a problem hiding this comment.
Don't know that this within() change is doing, but I trust you ;-) What's the source of this change? Any other PR?
Member
Author
the unselect table looks to be the closest one I could find. anyway the qe failed again. so will have to look at it once more: https://pulpito.ceph.com/nizamial09-2022-06-01_11:42:39-rados:dashboard-wip-nia-testing-2022-06-01-1326-distro-default-smithi/ |
Sarthak0702
reviewed
Jun 9, 2022
src/pybind/mgr/dashboard/frontend/src/app/shared/datatable/table/table.component.spec.ts
Outdated
Show resolved
Hide resolved
c470c21 to
ba798f3
Compare
Cypress sometimes fail to register the click and that causes the deselect/select to not happen properly. Deselecting the row immediately after performing the action makes it pass from cypress. Fixes: https://tracker.ceph.com/issues/55741 Signed-off-by: Nizamudeen A <nia@redhat.com>
ba798f3 to
dcf0445
Compare
Member
Author
|
QA run was successful |
Sarthak0702
approved these changes
Jun 13, 2022
Member
|
e2e failure unrelated to this (known issue): |
This was referenced Jun 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cypress sometimes fail to register the click and that causes the
deselect/select to not happen properly. Deselecting the row immediately
after performing the action makes it pass from cypress.
Fixes: https://tracker.ceph.com/issues/55741
Signed-off-by: Nizamudeen A nia@redhat.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows