Skip to content

rgw: user accounts implementation#46373

Closed
cbodley wants to merge 96 commits intoceph:mainfrom
cbodley:wip-rgw-account
Closed

rgw: user accounts implementation#46373
cbodley wants to merge 96 commits intoceph:mainfrom
cbodley:wip-rgw-account

Conversation

@cbodley
Copy link
Contributor

@cbodley cbodley commented May 23, 2022 •
edited
Loading

a rebase of #35726

adds an account metadata object with support for multisite sync, an account id to RGWUserInfo, and the following admin commands/APIs:

account create --account-name=A
account get --account-name=A
account rm --account-name=A
account user list --account-name=A
user modify --account-id=ID

TODO:

  • test cases for new account APIs in ceph_test_cls_user
  • add rgw::sal interfaces
  • add account ID for use in IAM policy ARNs. use a specific format (all-numeric?) to disambiguate between accounts and tenant names
  • namespace account names by tenant
  • user documentation, interaction with existing tenants

Future work:

  • add account roles
  • add account groups? ([DNM] rgw: REST APIs for AWS Groups. #20383)
  • account stats and quota (objects, bytes)
  • account rate limits
  • IAM APIs for account self-service and user management by 'account admin users' without global admin caps
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@cbodley cbodley requested a review from alimaredia May 23, 2022 19:09
@cbodley cbodley mentioned this pull request May 23, 2022
Closed
3 tasks
cbodley
cbodley commented May 24, 2022
View reviewed changes
@cbodley cbodley force-pushed the wip-rgw-account branch 4 times, most recently from 164abe0 to 31602b7 Compare May 25, 2022 19:55
@github-actions github-actions bot added the cephfs Ceph File System label May 25, 2022
@cbodley cbodley changed the base branch from master to main May 25, 2022 19:56
@cbodley cbodley removed cephfs Ceph File System build/ops labels May 25, 2022
@alimaredia
Copy link
Contributor

alimaredia commented May 26, 2022

@cbodley what's the purpose of rgw::sal::Account::load_account() and rgw::sal::Account::store_account()?

@cbodley
Copy link
Contributor Author

cbodley commented May 26, 2022

@cbodley what's the purpose of rgw::sal::Account::load_account() and rgw::sal::Account::store_account()?

to read/write RGWAccountInfo from the backend

@cbodley
Copy link
Contributor Author

cbodley commented May 31, 2022

jenkins test make check

cbodley
cbodley commented Jun 3, 2022
View reviewed changes
@cbodley cbodley force-pushed the wip-rgw-account branch from 2c866e6 to 76b321f Compare June 3, 2022 19:30
@cbodley cbodley marked this pull request as ready for review June 3, 2022 19:32
@github-actions
Copy link

github-actions bot commented Jun 13, 2022

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@theanalyst @cbodley
initial account commit
d98cd5c 
Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
@theanalyst @cbodley
rgw: services: introduce an RGWAccount interface
02dfa6d 
Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
cbodley and others added 12 commits June 23, 2022 11:27
@cbodley
radosgw-admin: split --account into --account-id and --account-name
648fa3f 
Signed-off-by: Casey Bodley <cbodley@redhat.com>
@cbodley
rgw: account interfaces take args by reference
da21d20 
Signed-off-by: Casey Bodley <cbodley@redhat.com>
@cbodley
rgw: require old account info for store/remove
2f40792 
Signed-off-by: Casey Bodley <cbodley@redhat.com>
@cbodley
rgw: add separate account name
a8d51c2 
Signed-off-by: Casey Bodley <cbodley@redhat.com>
@cbodley
rgw: add rados object for RGWAccountNameToId indirection
f210f05 
Signed-off-by: Casey Bodley <cbodley@redhat.com>
@cbodley
common: add gen_rand_numeric()
b06c42c 
Signed-off-by: Casey Bodley <cbodley@redhat.com>
@cbodley
rgw: add account name and id validation
0710d42 
Signed-off-by: Casey Bodley <cbodley@redhat.com>
@cbodley
rgw: account admin ops take id and/or name
d3da116 
Signed-off-by: Casey Bodley <cbodley@redhat.com>
@cbodley
radosgw-admin: add 'account modify' in addition to 'create'
5cb33e5 
Signed-off-by: Casey Bodley <cbodley@redhat.com>
@cbodley
radosgw-admin: add error messages to account operations
acd08f3 
Signed-off-by: Casey Bodley <cbodley@redhat.com>
@iqbalredkhan @cbodley
Add Account class with some functions
ea181eb 
Signed-off-by: Iqbal Khan <iqkhan@redhat.com>
@cbodley
rgw: use sal::Store to remove rados dependency
3e16c6a 
Signed-off-by: Casey Bodley <cbodley@redhat.com>
cbodley added 2 commits June 28, 2022 14:22
@cbodley
rgw: remove metadata backend stuff from account
bde13c4 
Signed-off-by: Casey Bodley <cbodley@redhat.com>
@cbodley
rgw: remove the RGWAccountCtl layer
a46c08f 
Signed-off-by: Casey Bodley <cbodley@redhat.com>
cbodley added 5 commits June 29, 2022 10:56
@cbodley
rgw: add account pools to RGWZoneParams json format
5b4c181 
Signed-off-by: Casey Bodley <cbodley@redhat.com>
@cbodley
rgw: add pool for account user listings
8c9531d 
Signed-off-by: Casey Bodley <cbodley@redhat.com>
@cbodley
rgw: admin rest APIs forward writes to master zone
50832f7 
Signed-off-by: Casey Bodley <cbodley@redhat.com>
@cbodley
rgw: update account linkage in RGWSI_User_RADOS
c4b1e40 
Signed-off-by: Casey Bodley <cbodley@redhat.com>
@cbodley
Revert "rgw: services: sysobj: introduce omap get/set header api"
9fd2aa9 
This reverts commit efc24f8.

Signed-off-by: Casey Bodley <cbodley@redhat.com>
@github-actions
Copy link

github-actions bot commented Jul 25, 2022

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@github-actions
Copy link

github-actions bot commented Mar 24, 2023

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Mar 24, 2023
@github-actions
Copy link

github-actions bot commented Apr 23, 2023

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!

@github-actions github-actions bot closed this Apr 23, 2023
@cbodley cbodley mentioned this pull request Nov 3, 2023
Merged
52 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dang dang dang approved these changes

@alimaredia alimaredia Awaiting requested review from alimaredia

Assignees

No one assigned

Labels

build/ops common feature needs-doc needs-rebase rgw stale tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cbodley @alimaredia @dang @theanalyst @iqbalredkhan