Skip to content

add some types from cls_rgw_ops.h to ceph-dencoder#46316

Closed
zhengp570 wants to merge 2 commits intoceph:mainfrom
zhengp570:n14.2.22
Closed

add some types from cls_rgw_ops.h to ceph-dencoder#46316
zhengp570 wants to merge 2 commits intoceph:mainfrom
zhengp570:n14.2.22

Conversation

@zhengp570
Copy link

New classes are declared in #include "cls/rgw/cls_rgw_ops.h"
Missing memeber functions are declared and defined
Fixes: https://tracker.ceph.com/issues/54054
Signed-off-by: zhengp570 zhengp570@gmail.com

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
    • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

Signed-off-by: zhengp570 <zhengp570@gmail.com>
@github-actions github-actions bot added the rgw label May 18, 2022
@cbodley cbodley requested a review from iqbalredkhan May 19, 2022 14:04
::encode_json("high_precision_time", high_precision_time, f);
}

void rgw_cls_obj_check_mtime::generate_test_instances(list<rgw_cls_obj_check_mtime *>& o) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cbodley , I have reviewed these changes, and all seems fine but I have difficulties in *void rgw_cls_obj_check_mtime::generate_test_instances(list<rgw_cls_obj_check_mtime >& o) function.
Please check once

@djgalloway djgalloway changed the base branch from master to main May 25, 2022 19:57
Signed-off-by: zhengp570 <zhengp570@gmail.com>
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Mar 23, 2023
@github-actions
Copy link

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!

@github-actions github-actions bot closed this Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants