Skip to content

octopus: qa/tasks: teuthology octopus backport#46149

Merged
ljflores merged 2 commits intoceph:octopusfrom
ljflores:wip-teuthology-octopus-backport
Jun 29, 2022
Merged

octopus: qa/tasks: teuthology octopus backport#46149
ljflores merged 2 commits intoceph:octopusfrom
ljflores:wip-teuthology-octopus-backport

Conversation

@ljflores
Copy link
Member

@ljflores ljflores commented May 4, 2022

Backport of #36718 and #37928.

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

This commit adds the file path of ceph log directories to the job's
info.yaml log file. The motivation behind this is, in case of job
timeout, the logs would still be tranferred to teuthology host
before nuking test machines using these ceph log directory paths in
job's info.yaml log file.

Signed-off-by: Shraddha Agrawal <shraddha.agrawal000@gmail.com>
(cherry picked from commit e991f04)
@github-actions github-actions bot added this to the octopus milestone May 4, 2022
@ljflores ljflores requested review from neha-ojha and zmc May 4, 2022 15:38
@ljflores
Copy link
Member Author

ljflores commented May 4, 2022

jenkins test make check

@neha-ojha
Copy link
Member

@ljflores do you want to test this PR with your reproducer for https://tracker.ceph.com/issues/51076, which we know results in dead jobs?

@ljflores
Copy link
Member Author

ljflores commented May 4, 2022

The Docs build failure is waiting on #45972, which I am also testing.

@ljflores
Copy link
Member Author

ljflores commented May 9, 2022

jenkins retest this please

for better readability

also update the comment in `ceph_crash()` to reflect the changed
settings

Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 43f2738)
@ljflores ljflores force-pushed the wip-teuthology-octopus-backport branch from 97eb206 to f272477 Compare May 10, 2022 15:45
@neha-ojha
Copy link
Member

@ljflores how's testing looking on this?

@ljflores
Copy link
Member Author

ljflores commented Jun 22, 2022

@neha-ojha I ran a reproducer awhile ago to see if this fixed the absence of remote logs, but I have a vague memory of it not working. That was some time ago though, so let me try and run another reproducer. Will update this with the results.

This test was an example of a dead job not collecting remote logs, so I will run this test and see if I can get it to die while collecting remote logs: http://pulpito.front.sepia.ceph.com/yuriw-2022-05-09_21:42:51-rados-wip-yuri2-testing-2022-04-26-1132-octopus-distro-default-smithi/6829091/.

Reproducer here. I will check the results of this to see if we've successfully captured logs for a dead job: http://pulpito.front.sepia.ceph.com/lflores-2022-06-28_19:36:24-rados:thrash-erasure-code-wip-yuri5-testing-2022-06-27-0923-octopus-distro-default-smithi/

@ljflores
Copy link
Member Author

Dead jobs now have captured logs. Merging!

@ljflores
Copy link
Member Author

jenkins test api

@ljflores ljflores merged commit 46c7999 into ceph:octopus Jun 29, 2022
@ljflores ljflores deleted the wip-teuthology-octopus-backport branch June 29, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants