tests: ceph_test_rados_api_watch_notify: LibRadosWatchNotify.AioWatch…#45840
tests: ceph_test_rados_api_watch_notify: LibRadosWatchNotify.AioWatch…#45840NitzanMordhai wants to merge 1 commit intoceph:mainfrom
Conversation
…Delete and Watch3Timeout reconnect During test LibRadosWatchNotify.AioWatchDelete or Watch3Timeout, rados_watch_check can return error -102 if reconnect happened, in that case Broken pipe reconnect and -102 returned Fixes: https://tracker.ceph.com/issues/52129 Signed-off-by: NitzanMordhai <nmordech@redhat.com>
rzarzynski
left a comment
There was a problem hiding this comment.
Current master normalizes the ENOENT into ENOTCONN at the Objecter layer.
bs::error_code Objecter::_normalize_watch_error(bs::error_code ec)
{
// translate ENOENT -> ENOTCONN so that a delete->disconnection
// notification and a failure to reconnect because we raced with
// the delete appear the same to the user.
if (ec == bs::errc::no_such_file_or_directory)
ec = bs::error_code(ENOTCONN, osd_category());
return ec;
}However, the mechanism isn't new as it got introduced in 2014 by c1dd92b. Hmm, should the tests mandate this behavior?
Most of the return error checked already changed, I don't think we have any more places we are checking for ENOENT -> ENOTCONN |
|
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
|
This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution! |
…Delete and Watch3Timeout reconnect
During test LibRadosWatchNotify.AioWatchDelete or Watch3Timeout, rados_watch_check can return error -102 if reconnect happened, in that case Broken pipe reconnect and -102 returned
Fixes: https://tracker.ceph.com/issues/52129
Signed-off-by: NitzanMordhai nmordech@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows