octopus:ImportError: cannot import name 'environmentfilter' from 'jinja2'#45839
octopus:ImportError: cannot import name 'environmentfilter' from 'jinja2'#45839RaminNietzsche wants to merge 1 commit intoceph:octopusfrom RaminNietzsche:fix_jinja2_version
Conversation
Date: Sun Apr 10 15:16925 2022 +0430 On branch fix_jinja2_version Changes to be committed: modified: admin/doc-requirements.txt modified: src/pybind/mgr/dashboard/constraints.txt modified: src/pybind/mgr/dashboard/constraints.txt Signed-off-by: Ramin Najarbashi <ramin.najarbashi@gmail.com>
idryomov
left a comment
There was a problem hiding this comment.
We do backports by cherry picking changes from the master branch with git cherry-pick -x so that the original commit hash is recorded in the changelog. E.g. for admin/doc-read-the-docs.txt change, you would need to do git cherry-pick -x 6a1dd3a8a2f3dc9fe8615d402c9041273516ff89.
I don't see the Jinja2 < 3.1 change is master though. Is master not affected, if so why?
@idryomov perhaps we need octopus backport for https://tracker.ceph.com/issues/55294 #45881 (comment) or if we do not want to update sphnix version then pinning Jinja version might help. |
|
@RaminNietzsche this might be a more straight-forward solution for the readthedocs failure: #46219. The Docs build failure has already been fixed by bumping the Sphinx version. |
Date: Sun Apr 10 15:16925 2022 +0430
On branch fix_jinja2_version
Changes to be committed:
modified: admin/doc-requirements.txt
Signed-off-by: Ramin Najarbashi ramin.najarbashi@gmail.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows