Remove orchestrator from rook task and suite#45749
Merged
ljflores merged 1 commit intoceph:masterfrom Apr 8, 2022
Merged
Conversation
This commit removes orchestrator commands from the Rook task and the Rook test suite because the Rook orchestrator is not being maintained, and the Rook orchestrator CLI is obsolete. This should also clarify the issue: https://tracker.ceph.com/issues/53680 Signed-off-by: Joseph Sawaya <jsawaya@redhat.com>
adk3798
approved these changes
Apr 1, 2022
Member
|
jenkins test api |
ljflores
approved these changes
Apr 1, 2022
Member
|
Thanks for this @josephsawaya ! |
Member
|
@travisn this PR passed the teuthology tests, so I think it is ready to merge. Tagging you though to make sure this is okay with rook. |
Member
|
jenkins test api |
jeffvance
reviewed
Apr 5, 2022
| @@ -1,8 +1,2 @@ | |||
| tasks: | |||
There was a problem hiding this comment.
do you still need this file? Is pretty much empty now...
travisn
reviewed
Apr 5, 2022
| 'storage': '10Gi' # <= (lte) the actual PV size | ||
| } | ||
| }, | ||
| 'storageClassName': 'scratch', |
Member
There was a problem hiding this comment.
Are the PVs from a scratch storage class defined somewhere in the test already? If not, we won't be seeing OSDs created.
Author
There was a problem hiding this comment.
The kubeadm task runs before the rook task is run, so the PVs and storage class are set up in that task
Line 452 in 57c2ae0
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes orchestrator commands from the
Rook task and the Rook test suite because the Rook
orchestrator is not being maintained, and the Rook
orchestrator CLI is obsolete. This should also
clarify the issue:
https://tracker.ceph.com/issues/53680
Signed-off-by: Joseph Sawaya jsawaya@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows