client: stop forwarding the request when exceeding 256 times#45688
Merged
vshankar merged 1 commit intoceph:masterfrom Apr 17, 2022
Merged
client: stop forwarding the request when exceeding 256 times#45688vshankar merged 1 commit intoceph:masterfrom
vshankar merged 1 commit intoceph:masterfrom
Conversation
Member
Author
|
Related to PR #45073 |
jtlayton
previously requested changes
Mar 29, 2022
d13a308 to
f40d643
Compare
luis-henrix
approved these changes
Mar 30, 2022
luis-henrix
left a comment
There was a problem hiding this comment.
This looks good to me, as it seems to follow the same logic as the kernel client.
Member
Author
Yeah, correct. Thanks! |
Contributor
|
@lxbsz I see that the commit message is missing 'Fixes: https://tracker.ceph.com/issues/55129' can you please add that? |
ajarr
reviewed
Mar 31, 2022
Member
Author
Done. Thanks. |
14 tasks
Contributor
|
jenkins retest this please |
The type of 'num_fwd' in ceph 'MClientRequestForward' is 'int32_t', while in 'ceph_mds_request_head' the type is '__u8'. So in case the request bounces between MDSes exceeding 256 times, the client will get stuck. In this case it's ususally a bug in MDS and continue bouncing the request makes no sense. Fixes: https://tracker.ceph.com/issues/55129 Signed-off-by: Xiubo Li <xiubli@redhat.com>
Member
Author
|
Nothing changed and just rebased to the latest upstream code. |
Contributor
|
jenkins test make check |
Contributor
This was referenced May 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The type of 'num_fwd' in ceph 'MClientRequestForward' is 'int32_t',
while in 'ceph_mds_request_head' the type is '__u8'. So in case
the request bounces between MDSes exceeding 256 times, the client
will get stuck.
In this case it's ususally a bug in MDS and continue bouncing the
request makes no sense.
Fixes: https://tracker.ceph.com/issues/55129
Signed-off-by: Xiubo Li xiubli@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows