mgr/dashboard: fix 01-hosts.e2e test error#45559
Conversation
Its a regression introduced by BDD testing ceph@79f8545 Fixes: https://tracker.ceph.com/issues/54990 Signed-off-by: Nizamudeen A <nia@redhat.com>
|
@nizamial09 can you please run teuthology to ensure 100% that the issue was fixed? Thanks! |
epuertat
left a comment
There was a problem hiding this comment.
LGTM. Thanks @nizamial09 for the quick fix!
| } | ||
| if (exist) { | ||
| cy.get('#hostname').should('have.class', 'ng-invalid'); | ||
| cy.get('cd-back-button').click(); |
There was a problem hiding this comment.
Makes sense, but what happened to this button? It'd be great if you add some more context to the PR description:
1) Hosts page
when Orchestrator is available
should not add an exsiting host:
AssertionError: Timed out retrying after 120000ms: Expected to find element: `cd-submit-button`, but never found it.
There was a problem hiding this comment.
@epuertat I accidentally introduced a back button (cd-back-button) while doing some testing with BDD and forgot to remove it. What this does is that, for a non existing host, test types the name and then immediately hits back (which cancels the form), but on the next line it check for the Submit button which is not found since the form is already cancelled.
I put this in the description too now, Thanks
|
jenkins test dashboard |
Its a regression introduced by BDD testing
79f8545
I accidentally introduced a back button (cd-back-button) while doing some testing with BDD and forgot to remove it. What this does is that, for a non existing host, test types the name and then immediately hits back (which cancels the form), but on the next line it check for the Submit button which is not found since the form is already cancelled.
Fixes: https://tracker.ceph.com/issues/54990
Signed-off-by: Nizamudeen A nia@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows