mgr/cephadm: Show warning when user provides --fsid option#45534
Merged
adk3798 merged 1 commit intoceph:masterfrom Mar 30, 2022
Merged
mgr/cephadm: Show warning when user provides --fsid option#45534adk3798 merged 1 commit intoceph:masterfrom
adk3798 merged 1 commit intoceph:masterfrom
Conversation
mgfritch
reviewed
Mar 21, 2022
Contributor
mgfritch
left a comment
There was a problem hiding this comment.
maybe this should be an error if the specified fsid already exists?
dd8cb2c to
d48d68e
Compare
Contributor
Author
|
Updated the code to show an explicit error if a cluster with the same fsid already exists. |
mgfritch
reviewed
Mar 21, 2022
Fixes: https://tracker.ceph.com/issues/50804 Signed-off-by: Redouane Kachach <rkachach@redhat.com>
d48d68e to
8780aa0
Compare
adk3798
approved these changes
Mar 23, 2022
Contributor
|
Failures: |
14 tasks
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/50804
Signed-off-by: Redouane Kachach rkachach@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows