cephadm: respect --skip-firewalld flag#45399
Merged
adk3798 merged 1 commit intoceph:masterfrom Mar 24, 2022
Merged
Conversation
mgfritch
approved these changes
Mar 16, 2022
Contributor
mgfritch
left a comment
There was a problem hiding this comment.
couple of nits, otherwise lgtm!
src/cephadm/tests/test_cephadm.py
Outdated
| @mock.patch('cephadm.logger') | ||
| @mock.patch('os.fchown') | ||
| def test_skip_firewalld(self, fchown, logger): | ||
| # test --skip-firewalld actually skips changing firewall |
Contributor
There was a problem hiding this comment.
should be a docstring comment ?
Contributor
Author
There was a problem hiding this comment.
is what's there now what you meant?
Contributor
Author
|
1 Dead job due to failing to power on a machine |
Contributor
Author
|
jenkins test make check |
Contributor
Author
|
jenkins test api |
Fixes: https://tracker.ceph.com/issues/54137 Signed-off-by: Adam King <adking@redhat.com>
Contributor
Author
|
2 Failures caused by wrong error code from host add command due to another PR included in the run |
14 tasks
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/54137
Signed-off-by: Adam King adking@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows