mgr/cephadm: try to get FQDN for configuration files#45333
Merged
adk3798 merged 2 commits intoceph:masterfrom Mar 22, 2022
Merged
mgr/cephadm: try to get FQDN for configuration files#45333adk3798 merged 2 commits intoceph:masterfrom
adk3798 merged 2 commits intoceph:masterfrom
Conversation
Member
|
jenkins test make check |
Member
Author
|
jenkins test make check |
votdev
approved these changes
Mar 11, 2022
Member
votdev
left a comment
There was a problem hiding this comment.
LGTM
The URLs are using FQDN where possible:
...
receivers:
- name: default
- name: ceph-dashboard
webhook_configs:
- send_resolved: true
http_config: {}
url: https://10.20.154.201:8443//api/prometheus_receiver
max_alerts: 0
- send_resolved: true
http_config: {}
url: https://node2.ses7p-default.test:8443/api/prometheus_receiver
max_alerts: 0
- send_resolved: true
http_config: {}
url: https://node3.ses7p-default.test:8443/api/prometheus_receiver
max_alerts: 0
- name: snmp-gateway
webhook_configs:
- send_resolved: true
http_config: {}
url: http://master.ses7p-default.test:9464/alerts
max_alerts: 0
Member
Author
|
jenkins test make check |
mgfritch
approved these changes
Mar 15, 2022
Contributor
|
jenkins test make check |
Member
Author
|
jenkins test make check |
3 tasks
adk3798
requested changes
Mar 18, 2022
added 2 commits
March 18, 2022 15:54
There are two different ways to get the host address. From the inventory of the mgr object directly or via the `_inventory_get_addr` method of `CephadmService`. Update the code in order to use the `_inventory_get_addr` method only. Signed-off-by: Tatjana Dehler <tdehler@suse.com>
Fixes: https://tracker.ceph.com/issues/54502 Signed-off-by: Tatjana Dehler <tdehler@suse.com>
Member
Author
|
jenkins test docs |
Member
Author
|
jenkins render docs |
Member
Author
|
jenkins test make check arm64 |
3 tasks
Contributor
|
1 Dead job due to failing to power on a machine |
adk3798
approved these changes
Mar 22, 2022
pcuzner
approved these changes
Mar 22, 2022
This was referenced Mar 24, 2022
14 tasks
14 tasks
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try to get the FQDN for an inventory address when generating configuration files. If it's not available fall back to the information from the inventory.
Fixes: https://tracker.ceph.com/issues/54502
Signed-off-by: Tatjana Dehler tdehler@suse.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows