mgr/cephadm: offline host watcher#45248
Merged
adk3798 merged 1 commit intoceph:masterfrom Mar 30, 2022
Merged
Conversation
Member
|
jenkins test make check |
mgfritch
reviewed
Mar 7, 2022
Contributor
mgfritch
left a comment
There was a problem hiding this comment.
I like this in general, but I think we need a more generic solution to handle the ssh timeout during the node offline use-case (https://tracker.ceph.com/issues/51733)
mgfritch
reviewed
Mar 22, 2022
To be able to detect if certain offline hosts go offline quicker. Could be useful for the NFS HA feature as this requires moving nfs daemons from offline hosts within 90 seconds. Signed-off-by: Adam King <adking@redhat.com>
Contributor
Author
|
NOTE: added in some of the changes autopep8 makes within the cephadm mgr module to this PR |
Contributor
Author
|
Failures: |
mgfritch
approved these changes
Mar 30, 2022
14 tasks
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be able to detect if certain offline hosts go
offline quicker. Could be useful for the NFS
HA feature as this requires moving nfs daemons from
offline hosts within 90 seconds.
Signed-off-by: Adam King adking@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox