test: osd-scrub-snaps.sh: fix expected 'missing snaps' log string#45239
Merged
ronen-fr merged 1 commit intoceph:masterfrom Mar 3, 2022
Merged
test: osd-scrub-snaps.sh: fix expected 'missing snaps' log string#45239ronen-fr merged 1 commit intoceph:masterfrom
ronen-fr merged 1 commit intoceph:masterfrom
Conversation
Fix the expected log message to match the scrub code, by removing the redundant part. Fixes: https://tracker.ceph.com/issues/54458 Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Contributor
Author
|
jenkins test make check |
neha-ojha
approved these changes
Mar 3, 2022
Contributor
Author
|
Merging w/o Teuthology tests: the test fixed here fails in Teu, so no harm can be caused by the proposed change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test expects the following line:
"...found snap mapper error on pg ... oid ... snaps missing in mapper, should be: 1,2,3,4,5,6,7 was r -2...repaired"
while up-to-date scrubber code does not emit the 'was r -2' part. As the list is always empty for missing snaps,
and the r is always '-2' - this part of the message is just confusing.
Fix the expected log message to match the scrub code, by removing the redundant part.
Fixes: https://tracker.ceph.com/issues/54458
Signed-off-by: Ronen Friedman rfriedma@redhat.com