mgr/cephadm: check spec host when adding osd#45217
Merged
adk3798 merged 1 commit intoceph:masterfrom Mar 30, 2022
Merged
Conversation
adk3798
reviewed
Mar 2, 2022
47bf103 to
a9bec95
Compare
Contributor
Author
|
jenkins retest this please |
a9bec95 to
29688ef
Compare
Contributor
|
Can we have a unit test added for this @rkachach ? |
29688ef to
b1d4857
Compare
Contributor
Author
|
@adk3798 UT has been added to check the new validation |
adk3798
approved these changes
Mar 22, 2022
Contributor
|
2 Failures caused by wrong error code from host add command due to another PR included in the run |
adk3798
requested changes
Mar 24, 2022
Fixes: https://tracker.ceph.com/issues/47872 Signed-off-by: Redouane Kachach <rkachach@redhat.com>
b1d4857 to
b87c966
Compare
adk3798
approved these changes
Mar 29, 2022
Contributor
|
Failures: |
14 tasks
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/47872
Signed-off-by: Redouane Kachach rkachach@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox