rgw: prevent spurious/lost notifications in the index completion thread#45212
Merged
cbodley merged 2 commits intoceph:masterfrom Mar 8, 2022
Merged
rgw: prevent spurious/lost notifications in the index completion thread#45212cbodley merged 2 commits intoceph:masterfrom
cbodley merged 2 commits intoceph:masterfrom
Conversation
this was happening when asyn completions happened during reshard. more information about testing: https://gist.github.com/yuvalif/d526c0a3a4c5b245b9e951a6c5a10517 we also add more logs to the completion manager. should allow finding unhandled completions due to reshards. Fixes: https://tracker.ceph.com/issues/54435 Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
yuvalif
approved these changes
Mar 1, 2022
Member
|
jenkins test make check |
Contributor
Author
|
@yuvalif seeing some UninitCondition and SyscallParam valgrind errors from this one in https://pulpito.ceph.com/cbodley-2022-03-04_14:14:50-rgw-wip-cbodley-testing-distro-default-smithi/ they're all under |
cbodley
commented
Mar 7, 2022
src/rgw/rgw_rados.cc
Outdated
Comment on lines
+814
to
+816
| std::thread retry_thread; | ||
| std::condition_variable cond; | ||
| std::mutex retry_completions_lock; |
Contributor
Author
There was a problem hiding this comment.
it may just be that retry_thread's constructor is being called before its cond and retry_completions_lock are?
resolves valgrind issues about RGWIndexCompletionManager::process() using uninitialized memory Signed-off-by: Casey Bodley <cbodley@redhat.com>
Contributor
Author
This was referenced Nov 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cbodley: cherry-picked from the wip-rgw-multisite-reshard feature branch after merge in #45131, so it can be backported to earlier releases. removed logging changes in
guard_reshard()due to conflicts with commit 85848c0 that's specific to multisite reshardFixes: https://tracker.ceph.com/issues/54435
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox